Opened 8 months ago

Closed 8 months ago

Last modified 7 months ago

#30021 closed defect (fixed)

Do not cache cipher list classification if cipher list is not yet available.

Reported by: nickm Owned by: nickm
Priority: High Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.8-alpha
Severity: Normal Keywords: tor-ci-fail-sometimes, ci, stem, ssl, 029-backport, 034-backport, 035-backport, asn-merge
Cc: teor, atagar Actual Points: .5
Parent ID: #29437 Points:
Reviewer: ahf Sponsor: Sponsor31-can

Description

See #29437 for motivation.

Child Tickets

Change History (15)

comment:1 Changed 8 months ago by nickm

Actual Points: .5
Status: assignedneeds_review

See branch bug30021_029 with PR at https://github.com/torproject/tor/pull/902 .

Merged forward to 0.3.5 as bug30021_035 with PR at https://github.com/torproject/tor/pull/903 and PR to master as https://github.com/torproject/tor/pull/904 .

For me, this successfully stops the stalling bugs with "make test-stem" and python>=3.6.

comment:2 Changed 8 months ago by nickm

Keywords: 029-backport 034-backport 035-backport added

comment:3 Changed 8 months ago by nickm

Cc: teor atagar added

comment:4 Changed 8 months ago by ahf

Reviewer: ahf
Status: needs_reviewmerge_ready

I think this change looks good.

comment:5 Changed 8 months ago by nickm

Component: Core Tor/StemCore Tor/Tor

comment:6 Changed 8 months ago by nickm

Keywords: asn-merge added

comment:7 Changed 8 months ago by nickm

Keywords: teor-merge added

whoever gets to this first should give it a merge IMO :)

comment:8 Changed 8 months ago by nickm

Keywords: teor-merge removed

batch-modify: asn has offered to merge these tomorrow, so removing them from teor's plate. Teor -- you can merge these anyway if you are blocked on any of them and it would save you time to do so.

comment:9 Changed 8 months ago by asn

Resolution: fixed
Status: merge_readyclosed

merged to 040 and forward.

comment:10 Changed 8 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: closedreopened

comment:11 Changed 8 months ago by nickm

Status: reopenedmerge_ready

Reopened as backport candidate. We need this everywhere that we want "test-stem" to pass reliably, and there are probably other openssl weirdnesses that it solves as well.

comment:12 Changed 8 months ago by teor

Resolution: fixed
Status: merge_readyclosed

comment:13 Changed 8 months ago by teor

Milestone: Tor: 0.3.5.x-finalTor: 0.2.9.x-final

comment:14 Changed 8 months ago by teor

Version: Tor: 0.2.4.8-alpha

comment:15 Changed 7 months ago by teor

Sponsor: Sponsor31-can

Setting as sponsor 31 can, because we use these jobs to make sure our refactoring works.

Note: See TracTickets for help on using tickets.