Opened 7 months ago

Closed 6 months ago

#30039 closed task (fixed)

Add options to be able to prepend or append targets

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/rbm Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201904R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When listing an other project in input_files, it is possible to specify other targets which will be used to build this project.

In tor-browser-build we do this for example in projects/https-everywhere/config to use the common-stretch target and avoid building a different python for each platform.

The issue however with setting target is that it is replacing any previous target. In many cases however it would be useful to keep the previous targets and only append or prepend some other targets.

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by boklm

Keywords: TorBrowserTeam201904R added
Status: newneeds_review

There is a rbm patch in branch bug_30039, adding the target_append and target_prepend options:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_30039&id=87adfb7b7be7e7e0f437020dbf8a119673133412

There is a tor-browser-build patch in branch bug_30039_v2 updating the rbm commit, and using the target_prepend option in https-everywhere:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30039_v2&id=ca406daeb0b25f6109042effebad59204a8b05b1

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201904R removed
Status: needs_reviewneeds_revision

I merged the rbm patch (commit 87adfb7b7be7e7e0f437020dbf8a119673133412).

The tor-browser-build patch looks good but the commit message contains some typos I think:

s/instead of the prepend option/instead of the target option/

"in the python python" <- not sure what is meant with the second "python".

comment:3 Changed 6 months ago by boklm

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed
Status: needs_revisionneeds_review

comment:4 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good and merged to master (commit ed424fd45a740f1b62857456fbcf616976012986).

Note: See TracTickets for help on using tickets.