Opened 3 months ago

Closed 4 weeks ago

#30050 closed task (implemented)

Disable practracker in CI, when a release becomes a release candidate

Reported by: teor Owned by:
Priority: High Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Major Keywords: practracker, tech-debt, tor-ci-fail-sometimes, 041-deferred-20190530
Cc: gaba Actual Points:
Parent ID: #30835 Points: 1
Reviewer: Sponsor: Sponsor31-can

Description

  • we get practracker on master, where it is most useful
  • we keep practracker in alphas, where we still get some large code changes
  • we don't have to worry about practracker for backports:
    • we rely on the existing backport triage process to maintain code quality in backport branches
    • we don't need practracker for backport branches, because we (usually) don't make large changes to backport branches

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by nickm

Keywords: 040-must removed
Milestone: Tor: 0.4.0.x-finalTor: 0.4.1.x-final

0.4.0 doesn't have practracker; this can be an 041 ticket, I believe.

comment:2 Changed 8 weeks ago by teor

Sponsor: Sponsor31-can

These can be sponsor 31, if we want them to be.

comment:3 Changed 7 weeks ago by nickm

Keywords: 041-deferred-20190530 added

Marking these tickets as deferred from 041.

comment:4 Changed 7 weeks ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final

comment:5 Changed 4 weeks ago by teor

Here's how we do this change:
nickm: I think it would be removing "check-best-practices" from "check-local"

comment:6 Changed 4 weeks ago by teor

Parent ID: #29792#30835

comment:7 Changed 4 weeks ago by teor

Cc: gaba added
Keywords: tor-ci-fail-sometimes added; tor-ci removed
Priority: MediumHigh
Severity: NormalMajor

This is causing more CI failures than we are comfortable with.

Gaba, this is a practracker bug fix, so it belongs in Sponsor 31.

comment:8 Changed 4 weeks ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.1.x-final
Resolution: implemented
Status: newclosed

Done in 4ecd09cfb7c5d43450d481807f60feb0aa98bccf.

Note: See TracTickets for help on using tickets.