Opened 6 months ago

Closed 6 months ago

#30058 closed defect (fixed)

Chutney bootstrap-network script uses the wrong network flavour

Reported by: opara Owned by: teor
Priority: Low Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: fast-fix, chutney-ci, network-team-roadmap-2019-Q1Q2
Cc: teor Actual Points: 0.1
Parent ID: #29729 Points: 0.1
Reviewer: nickm Sponsor: Sponsor19

Description

The 'tools/bootstrap-network.sh' script doesn't actually use its program argument (the network flavour). This means that the incorrect network is started.

The line:

export CHUTNEY_NETWORK="$CHUTNEY_PATH/networks/$NETWORK_FLAVOUR"

should be:

export CHUTNEY_NETWORK="$CHUTNEY_PATH/networks/$flavour"

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by teor

Actual Points: 0.1
Keywords: chutney-ci network-team-roadmap-2019-Q1Q2 added
Owner: set to teor
Parent ID: #29729
Points: 0.1
Sponsor: Sponsor19
Status: newassigned

Thanks for reporting this bug!

This issue doesn't affect bootstrap-network.sh when it's called from test-network.sh. But we should fix the variable confusion.

comment:2 Changed 6 months ago by teor

Keywords: fast-fix added
Reviewer: nickm
Status: assignedneeds_review

Another quick fix for some logging and argument-handling errors in bootstrap-network.sh:
https://github.com/torproject/chutney/pull/17

Assigning to nickm for review, because it's all related. :-)

comment:3 Changed 6 months ago by nickm

Status: needs_reviewneeds_revision

Looks mostly okay but I think it will fail shellcheck. Maybe we should fix that before we merge?

(If it doesn't fail shellcheck, then it's fine to go ahead and merge anyway)

comment:4 in reply to:  3 Changed 6 months ago by teor

Resolution: fixed
Status: needs_revisionclosed

Replying to nickm:

Looks mostly okay but I think it will fail shellcheck. Maybe we should fix that before we merge?

(If it doesn't fail shellcheck, then it's fine to go ahead and merge anyway)

shellcheck seems fine: it only warns on export VAR="$(command)".

Merged to master.

Note: See TracTickets for help on using tickets.