Opened 4 months ago

Closed 3 months ago

#30063 closed enhancement (fixed)

Add unit tests to chutney, and run them in Travis

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: chutney-ci, network-team-roadmap-2019-Q1Q2
Cc: teor Actual Points: 0.2
Parent ID: #29729 Points: 0.2
Reviewer: nickm Sponsor: Sponsor19

Description

In #29729, we want to add unit tests for each chutney module.

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by teor

Reviewer: nickm
Status: assignedneeds_review

comment:2 Changed 4 months ago by teor

Actual Points: 0.2
Points: 0.2

comment:3 Changed 4 months ago by teor

Type: defectenhancement

comment:4 Changed 4 months ago by nickm

Status: needs_reviewmerge_ready

I'm okay merging this as-is, but in the future we should probably use a real unit-testing framework (e.g. the builtin unittest module). If we want to keep using the shell to launch certain tests, we should probably have a separate script for each nontrivial test.

Let's open a ticket for those if we merge this as-is.

comment:5 in reply to:  4 Changed 3 months ago by teor

Replying to nickm:

I'm okay merging this as-is, but in the future we should probably use a real unit-testing framework (e.g. the builtin unittest module). If we want to keep using the shell to launch certain tests, we should probably have a separate script for each nontrivial test.

Let's open a ticket for those if we merge this as-is.

Opened #30154 and #30155 for these issues.

comment:6 Changed 3 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to master.

I merged #30059, #30063, #30064, and #30065, then pushed.

Note: See TracTickets for help on using tickets.