Opened 6 months ago

Closed 6 months ago

#30065 closed enhancement (fixed)

Add shellcheck tests to chutney

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: chutney-ci, network-team-roadmap-2019-Q1Q2
Cc: teor Actual Points: 0.2
Parent ID: #29729 Points: 0.2
Reviewer: nickm Sponsor: Sponsor19

Description

Let's be just like Tor.

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by teor

Status: assignedneeds_review

comment:2 Changed 6 months ago by teor

Type: defectenhancement

comment:3 Changed 6 months ago by nickm

Status: needs_reviewmerge_ready

This LGTM, modulo rl1987's comment.

comment:4 in reply to:  3 Changed 6 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Replying to nickm:

This LGTM, modulo rl1987's comment.

I replied to rl1987's comment. I think it's good practice to explicitly list our dependencies, and insulate ourselves from future travis changes.

Merged to master.
Put the shellcheck tests before the unit tests when resolving a conflict.

I merged #30059, #30063, #30064, and #30065, then pushed.

Note: See TracTickets for help on using tickets.