Opened 12 days ago

Last modified 11 days ago

#30076 needs_review defect

shellcheck: contrib/dist/suse/tor.sh.in issues

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In contrib/dist/suse/tor.sh.in line 29:
. /etc/rc.status
  ^------------^ SC1091: Not following: /etc/rc.status was not specified as input (see shellcheck -x).


In contrib/dist/suse/tor.sh.in line 44:
ulimit -n 8192
       ^-- SC2039: In POSIX sh, ulimit -n is undefined.


In contrib/dist/suse/tor.sh.in line 65:
    SUPROG=/bin/su
    ^----^ SC2034: SUPROG appears unused. Verify use (or export if used externally).


In contrib/dist/suse/tor.sh.in line 115:
    RETVAL=1
    ^----^ SC2034: RETVAL appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RETVAL appears unused. Verify use...
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, ulimit -n is undefin...
  https://www.shellcheck.net/wiki/SC1091 -- Not following: /etc/rc.status was...

Child Tickets

Change History (3)

comment:1 Changed 12 days ago by nickm

Milestone: Tor: 0.4.1.x-final

batch-assigning shellcheck tickets to 0.4.1

comment:2 Changed 11 days ago by rl1987

This was written in 2006-2007 by Andrew Lewman and had only 2 commits that touch it since then. It also relies on torctl, which I guess is no longer a thing?

I propose we remove this file from the repository.

comment:3 Changed 11 days ago by rl1987

Status: newneeds_review
Note: See TracTickets for help on using tickets.