Opened 6 months ago

Closed 5 months ago

#30076 closed defect (fixed)

shellcheck: contrib/dist/suse/tor.sh.in issues

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

In contrib/dist/suse/tor.sh.in line 29:
. /etc/rc.status
  ^------------^ SC1091: Not following: /etc/rc.status was not specified as input (see shellcheck -x).


In contrib/dist/suse/tor.sh.in line 44:
ulimit -n 8192
       ^-- SC2039: In POSIX sh, ulimit -n is undefined.


In contrib/dist/suse/tor.sh.in line 65:
    SUPROG=/bin/su
    ^----^ SC2034: SUPROG appears unused. Verify use (or export if used externally).


In contrib/dist/suse/tor.sh.in line 115:
    RETVAL=1
    ^----^ SC2034: RETVAL appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RETVAL appears unused. Verify use...
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, ulimit -n is undefin...
  https://www.shellcheck.net/wiki/SC1091 -- Not following: /etc/rc.status was...

Child Tickets

Change History (11)

comment:1 Changed 6 months ago by nickm

Milestone: Tor: 0.4.1.x-final

batch-assigning shellcheck tickets to 0.4.1

comment:2 Changed 6 months ago by rl1987

This was written in 2006-2007 by Andrew Lewman and had only 2 commits that touch it since then. It also relies on torctl, which I guess is no longer a thing?

I propose we remove this file from the repository.

comment:3 Changed 6 months ago by rl1987

Status: newneeds_review

comment:4 Changed 5 months ago by asn

Reviewer: nickm

comment:5 Changed 5 months ago by nickm

Status: needs_reviewmerge_ready

LGTM.

comment:6 Changed 5 months ago by nickm

Keywords: asn-merge added

comment:7 Changed 5 months ago by asn

There were conflicts in this branch. Resolved and opened PR: https://github.com/torproject/tor/pull/979

comment:8 Changed 5 months ago by asn

Status: merge_readyneeds_revision

Hm, having trouble with the conflict resolution here. rl1987 would it be possible to rebase this to latest master and turn this back into merge_ready? Thanks!

comment:9 Changed 5 months ago by rl1987

Rebased and made make distcheck work again: https://github.com/torproject/tor/pull/985

comment:10 Changed 5 months ago by rl1987

Status: needs_revisionmerge_ready

comment:11 Changed 5 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.