Opened 2 months ago

Closed 8 weeks ago

#30077 closed defect (implemented)

shellcheck: src/test/fuzz/fuzz_multi.sh issues

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

In ./src/test/fuzz/fuzz_multi.sh line 1:
MEMLIMIT_BYTES=21990500990976
^-- SC2148: Tips depend on target shell and yours is unknown. Add a shebang.


In ./src/test/fuzz/fuzz_multi.sh line 9:
FILTER=echo
^----^ SC2209: Use var=$(command) to assign output (or quote to assign string).


In ./src/test/fuzz/fuzz_multi.sh line 11:
for i in `seq -w "$N_CPUS"`; do
         ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`.

For more information:
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
  https://www.shellcheck.net/wiki/SC2209 -- Use var=$(command) to assign outp...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by nickm

Milestone: Tor: 0.4.1.x-final

batch-assigning shellcheck tickets to 0.4.1

comment:2 Changed 2 months ago by rl1987

Status: newneeds_review

comment:3 Changed 2 months ago by asn

Reviewer: ahf

comment:4 Changed 8 weeks ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:5 Changed 8 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.