Opened 3 months ago

Closed 3 months ago

#30078 closed defect (fixed)

shellcheck: src/test/fuzz/fixup_filenames.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

In ./src/test/fuzz/fixup_filenames.sh line 11:
    prev=`basename "$fn"`
         ^--------------^ SC2006: Use $(...) notation instead of legacy backticked `...`.


In ./src/test/fuzz/fixup_filenames.sh line 12:
    post=`sha256sum "$fn" | sed -e 's/ .*//;'`
         ^-- SC2006: Use $(...) notation instead of legacy backticked `...`.


In ./src/test/fuzz/fixup_filenames.sh line 13:
    if [ "$prev" == "$post" ] ; then
                 ^-- SC2039: In POSIX sh, == in place of = is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, == in place of = is ...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by nickm

Milestone: Tor: 0.4.1.x-final

batch-assigning shellcheck tickets to 0.4.1

comment:2 Changed 3 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 3 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 3 months ago by asn

Reviewer: mikeperry

comment:5 Changed 3 months ago by mikeperry

Status: needs_reviewmerge_ready

This looks good.

comment:6 Changed 3 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.