Skip to content
Snippets Groups Projects
New look: Off

Tor Browser for Android: Sync Sign-In Button crashes

    • Closed (moved) Issue created by cypherpunks @cypherpunks

    Steps to reproduce:

    1. goto browsing history: Press "synced devices 0 devices"
    2. Press Sync Sign-In Button and it crashes Tor Browser instantly.
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • cypherpunks added TorBrowserTeam201904 component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-8.5-must tbb-crash tbb.mobile type::defect labels

      added TorBrowserTeam201904 component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-8.5-must tbb-crash tbb.mobile type::defect labels

    • S
      Matthew Finkel @sysrqb ·

      Neat. Thanks for reporting this.

      --------- beginning of crash
04-08 18:30:22.703 17942 17942 E AndroidRuntime: FATAL EXCEPTION: main
04-08 18:30:22.703 17942 17942 E AndroidRuntime: Process: org.torproject.torbrowser_alpha, PID: 17942
04-08 18:30:22.703 17942 17942 E AndroidRuntime: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=org.torproject.torbrowser_alpha.ACTION_FXA_GET_STARTED }
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2007)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.app.Instrumentation.execStartActivity(Instrumentation.java:1673)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.app.Activity.startActivityForResult(Activity.java:4586)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.ActivityCompatJB.startActivityForResult(ActivityCompatJB.java:30)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.ActivityCompat.startActivityForResult(ActivityCompat.java:162)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.FragmentActivity.startActivityFromFragment(FragmentActivity.java:914)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.FragmentActivity$HostCallbacks.onStartActivityFromFragment(FragmentActivity.java:1009)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.Fragment.startActivity(Fragment.java:921)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.support.v4.app.Fragment.startActivity(Fragment.java:910)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at org.mozilla.gecko.home.CombinedHistoryPanel$2.onClick(CombinedHistoryPanel.java:240)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.view.View.performClick(View.java:6597)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.view.View.performClickInternal(View.java:6574)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.view.View.access$3100(View.java:778)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.view.View$PerformClick.run(View.java:25885)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:873)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:193)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6669)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
04-08 18:30:22.703 17942 17942 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler: >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 2 ("main")
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=org.torproject.torbrowser_alpha.ACTION_FXA_GET_STARTED }
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2007)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.app.Instrumentation.execStartActivity(Instrumentation.java:1673)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.app.Activity.startActivityForResult(Activity.java:4586)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.ActivityCompatJB.startActivityForResult(ActivityCompatJB.java:30)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.ActivityCompat.startActivityForResult(ActivityCompat.java:162)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.FragmentActivity.startActivityFromFragment(FragmentActivity.java:914)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.FragmentActivity$HostCallbacks.onStartActivityFromFragment(FragmentActivity.java:1009)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.Fragment.startActivity(Fragment.java:921)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.support.v4.app.Fragment.startActivity(Fragment.java:910)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at org.mozilla.gecko.home.CombinedHistoryPanel$2.onClick(CombinedHistoryPanel.java:240)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.view.View.performClick(View.java:6597)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at org.mozilla.gecko.home.CombinedHistoryPanel$2.onClick(CombinedHistoryPanel.java:240)                                                            [0/1811]
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.view.View.performClick(View.java:6597)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.view.View.performClickInternal(View.java:6574)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.view.View.access$3100(View.java:778)                            
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.view.View$PerformClick.run(View.java:25885)                                                                     
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.os.Handler.handleCallback(Handler.java:873)                                                                       
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.os.Handler.dispatchMessage(Handler.java:99)                                                                     
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.os.Looper.loop(Looper.java:193)                                                                                   
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at android.app.ActivityThread.main(ActivityThread.java:6669)                                                               
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at java.lang.reflect.Method.invoke(Native Method)                                                                            
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
04-08 18:30:22.703 17942 17942 E GeckoCrashHandler:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

      In mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java:

      232         // Set up Clients empty view.
233         final Button syncSetupButton = (Button) mClientsEmptyView.findViewById(R.id.sync_setup_button);
234         syncSetupButton.setOnClickListener(new View.OnClickListener() {
235             @Override
236             public void onClick(View view) {
237                 Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, "history_syncsetup");
238                 // This Activity will redirect to the correct Activity as needed.
239                 final Intent intent = new Intent(FxAccountConstants.ACTION_FXA_GET_STARTED);                                                                                                                   
240                 startActivity(intent);
241             }
242         });
    • Georg Koppen
      Georg Koppen @gk ·

      Trac:
      Version: Tor: 0.3.5.8 to N/A
      Keywords: Browser Android deleted, tbb.mobile, tbb-8.5-must, tbb-crash, TorBrowserTeam201904 added
      Priority: Medium to High
      Severity: Major to Normal

    • C
      cypherpunks @cypherpunks ·
      Author

      i can confirm to reproduce this on multiple android versions.

    • S
      Matthew Finkel @sysrqb ·

      I have a branch that prevents this crash and it shows a dialog with a message saying "Sync is not currently supported in Tor Browser on Android". The branch also avoids additional crashes related to the issue by commenting out setOverrideIntentAction() and launchFxASetup(). Branch bug30086_00 in my repo.

      Trac:
      Status: new to needs_review

    • S
      Matthew Finkel @sysrqb ·

      New branch for review, bug30086_01.

      I discussed this with gk, I made two small changes:

      • typo in the string, s/current/currently/
      • Deleted the change in SyncPreference.java
    • Georg Koppen
      Georg Koppen @gk ·

      Looks good now, thanks! Merged to tor-browser-60.6.1esr-8.5-1 (commit 128f8ebdc9d460f4df550b5977ef30bd6ff4e302).

      Trac:
      Status: needs_review to closed
      Resolution: N/A to fixed

    • Trac closed

      closed

    • Trac moved to tpo/applications/tor-browser#30086 (closed)

      moved to tpo/applications/tor-browser#30086 (closed)

    Please register or sign in to reply