Opened 8 months ago

Closed 8 months ago

#30089 closed task (fixed)

Use apksigner instead of jarsigner

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201904R
Cc: hans@…, sisbell Actual Points:
Parent ID: #29981 Points:
Reviewer: Sponsor:

Description

In projects/tor-browser/build.android we currently use jarsigner to sign the apk.

In order to make the build reproducible, we run it with faketime. However doing that leads to a stalled build on Stretch, so we are using Buster as a workaround.

According to eighthave this issue might be solved by using apksigner instead of jarsigner:
https://trac.torproject.org/projects/tor/ticket/29981#comment:4

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by boklm

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed
Status: newneeds_review

There is a patch for review in branch bug_30089_v3:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30089_v3&id=3adfba1a00e8faef561e1c74a7dc00cdac3ed3fc

I have done two builds for android-armv7 and android-x86 with this patch, and the builds were matching. So using apksigner allows us to stop using faketime, and build on stretch.

comment:2 Changed 8 months ago by gk

Nice! It seems we can remove the buster parts in debootstrap-image/config as well, no? There should be no buster consumer anymore with the proposed changes in this patch.

comment:4 Changed 8 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks looks good now. This made into into master with commit c14145264cd1f8eaff3a465d0014d5bf1d061e8a.

Note: See TracTickets for help on using tickets.