Opened 8 years ago

Closed 8 years ago

#3009 closed defect (fixed)

Polipo is included (yet should not be?) in TBB 2.2.24-1 alpha (Windows)

Reported by: HG2G Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Privoxy is included in TBB 2.2.24-1 alpha for Windows even though Privoxy is not needed. I tested setting TorButton to 'custom' with only SOCKS proxy set*, thus bypassing Privoxy, and TBB passed all 'Tor checks' (e.g., https://check.torproject.org). Using DNSEye there are no DNS leaks and I did not have any timeout erros when only using SOCKS proxy setting in Firefox.

Testing TBB 2.2.24-1 alpha (Firefox) page load speed with FireBug and HammerHead showed faster page load times without Privoxy vs with Privoxy for https://torproject.org, https://blog.torproject.org and http://kpvz7ki2v5agwt35.onion/wiki/index.php/Main_Page.

  • I added these lines to user.js:
user_pref("extensions.torbutton.http_port", 0);
user_pref("extensions.torbutton.http_proxy", );
user_pref("extensions.torbutton.https_port", 0);
user_pref("extensions.torbutton.https_proxy", );
user_pref("extensions.torbutton.socks_host", "127.0.0.1");
user_pref("extensions.torbutton.socks_port", 9050);
user_pref("extensions.torbutton.settings_method", "custom");


Child Tickets

Change History (8)

comment:1 Changed 8 years ago by HG2G

Err, I meant Polipo, not Privoxy; sorry about that. Time for some coffee!

comment:2 in reply to:  description ; Changed 8 years ago by rransom

Summary: Privoxy is included (yet should not be?) in TBB 2.2.24-1 alpha (Windows)Polipo is included (yet should not be?) in TBB 2.2.24-1 alpha (Windows)

Replying to HG2G:

Privoxy is included in TBB 2.2.24-1 alpha for Windows even though Privoxy is not needed. I tested setting TorButton to 'custom' with only SOCKS proxy set*, thus bypassing Privoxy, and TBB passed all 'Tor checks' (e.g., https://check.torproject.org). Using DNSEye there are no DNS leaks and I did not have any timeout erros when only using SOCKS proxy setting in Firefox.

Unchecking the ‘Use Polipo’ checkbox in Torbutton's ‘Preferences’ dialog is easier.

We aren't worried about DNS leaks anymore -- Polipo has been included in the recent non-alpha releases purely in order to work around a hard-coded timeout in Firefox's SOCKS client support.

Testing TBB 2.2.24-1 alpha (Firefox) page load speed with FireBug and HammerHead showed faster page load times without Privoxy vs with Privoxy for https://torproject.org, https://blog.torproject.org and http://kpvz7ki2v5agwt35.onion/wiki/index.php/Main_Page.

But since you could browse to a hidden service, it's likely that the copy of Firefox in that TBB is patched to fix the SOCKS timeout bug (as it should be), so Polipo is unnecessary.

comment:3 in reply to:  2 ; Changed 8 years ago by HG2G

Hello Robert,

Replying to rransom:

Replying to HG2G:

Privoxy is included in TBB 2.2.24-1 alpha for Windows even though Privoxy is not needed. I tested setting TorButton to 'custom' with only SOCKS proxy set*, thus bypassing Privoxy, and TBB passed all 'Tor checks' (e.g., https://check.torproject.org). Using DNSEye there are no DNS leaks and I did not have any timeout erros when only using SOCKS proxy setting in Firefox.

Unchecking the ‘Use Polipo’ checkbox in Torbutton's ‘Preferences’ dialog is easier.

We aren't worried about DNS leaks anymore -- Polipo has been included in the recent non-alpha releases purely in order to work around a hard-coded timeout in Firefox's SOCKS client support.

Yup, uncheckable "Use Polipo" and then checking "Use Custom Proxy Settings" is easier, but I wanted to test TBB from 1st start-up without using Polipo and Polipo settings. I realize DNS leaks were not an issue when using Polipo re its correct socks 5 code and Firefox 'not doing DNS lookups locally' (i.e., TorButton configuration of user_pref("network.proxy.socks_remote_dns", true);. However, I wanted to check and ensure the new socks patch for Firefox 4 in TBB 2.2.24-1 alpha was working as expected (that is, handling DNS properly).

Testing TBB 2.2.24-1 alpha (Firefox) page load speed with FireBug and HammerHead showed faster page load times without Privoxy vs with Privoxy for https://torproject.org, https://blog.torproject.org and http://kpvz7ki2v5agwt35.onion/wiki/index.php/Main_Page.

But since you could browse to a hidden service, it's likely that the copy of Firefox in that TBB is patched to fix the SOCKS timeout bug (as it should be), so Polipo is unnecessary.

Yup, that was my point for posting this report, but I didn't want to be too presumptuous and state for a fact Polipo should not be included (after all, I am just some random person, no one of import to the Tor Project). I asked Erinn about this a (few?) weeks ago, re whether the socks patch will be included in the new Tor Project fork of FF 4 with new TBB version(s), and she told me yes, the patch will be included. I agree Polipo should not be included in new TBBs (with FF 4) any longer, but I didn't want to overstep my bounds considering I am a nobody to the Tor project.

P.S. Thanks for fixing the title.

comment:4 Changed 8 years ago by HG2G

rransom: forgive me if your name is not Robert, I thought it was, but now I believe I may have been thinking about Robert Hogan.

comment:5 in reply to:  3 Changed 8 years ago by rransom

Replying to HG2G:

Privoxy is included in TBB 2.2.24-1 alpha for Windows even though Privoxy is not needed. I tested setting TorButton to 'custom' with only SOCKS proxy set*, thus bypassing Privoxy, and TBB passed all 'Tor checks' (e.g., https://check.torproject.org). Using DNSEye there are no DNS leaks and I did not have any timeout erros when only using SOCKS proxy setting in Firefox.

Unchecking the ‘Use Polipo’ checkbox in Torbutton's ‘Preferences’ dialog is easier.

We aren't worried about DNS leaks anymore -- Polipo has been included in the recent non-alpha releases purely in order to work around a hard-coded timeout in Firefox's SOCKS client support.

Yup, uncheckable "Use Polipo" and then checking "Use Custom Proxy Settings" is easier, but I wanted to test TBB from 1st start-up without using Polipo and Polipo settings. I realize DNS leaks were not an issue when using Polipo re its correct socks 5 code and Firefox 'not doing DNS lookups locally' (i.e., TorButton configuration of user_pref("network.proxy.socks_remote_dns", true);. However, I wanted to check and ensure the new socks patch for Firefox 4 in TBB 2.2.24-1 alpha was working as expected (that is, handling DNS properly).

Thanks! That sort of testing is important.

Testing TBB 2.2.24-1 alpha (Firefox) page load speed with FireBug and HammerHead showed faster page load times without Privoxy vs with Privoxy for https://torproject.org, https://blog.torproject.org and http://kpvz7ki2v5agwt35.onion/wiki/index.php/Main_Page.

But since you could browse to a hidden service, it's likely that the copy of Firefox in that TBB is patched to fix the SOCKS timeout bug (as it should be), so Polipo is unnecessary.

Yup, that was my point for posting this report, but I didn't want to be too presumptuous and state for a fact Polipo should not be included (after all, I am just some random person, no one of import to the Tor Project). I asked Erinn about this a (few?) weeks ago, re whether the socks patch will be included in the new Tor Project fork of FF 4 with new TBB version(s), and she told me yes, the patch will be included. I agree Polipo should not be included in new TBBs (with FF 4) any longer, but I didn't want to overstep my bounds considering I am a nobody to the Tor project.

You just submitted at least five (more than I could easily count) useful bug reports for TBB, along with useful information about several other TBB bug reports. You're not a ‘nobody.’

Replying to HG2G:

rransom: forgive me if your name is not Robert, I thought it was, but now I believe I may have been thinking about Robert Hogan.

It is.

comment:6 Changed 8 years ago by erinn

Status: newaccepted

Hi HG2G,

Thanks again for all of these very thorough bug reports and great testing. I am perplexed by this one since Windows is the only platform I don't build Firefox 4 on and, as far as I know, the timeout patch has not been applied to this version.

I'm going to leave this open for now but hopefully I can remove Polipo from the next bundle, either because we don't need it due to upstream patching or because I've started building FF4 on Windows from source.

comment:7 in reply to:  6 Changed 8 years ago by HG2G

Replying to erinn:

Hi HG2G,

Thanks again for all of these very thorough bug reports and great testing. I am perplexed by this one since Windows is the only platform I don't build Firefox 4 on and, as far as I know, the timeout patch has not been applied to this version.

I'm going to leave this open for now but hopefully I can remove Polipo from the next bundle, either because we don't need it due to upstream patching or because I've started building FF4 on Windows from source.

Hello,

You didn't apply the socks patch the Windows FF 4? Where does Tor get the portable Windows Firefox, from PortableApps?

Unless the guy from PortableApps included the socks patch and Tor used his build, I do not understand why I can skip using Polipo, even on Hidden Services (tho I still get timeout error on occasion, I guess if the HS or route is too slow). I am using the Firefox 4 Tor Bundle now, without Polipo, and the 'normal' Internet is better than with Polipo, IMO anyway.

comment:8 Changed 8 years ago by erinn

Resolution: fixed
Status: acceptedclosed

Polipo is no longer present in the experimental bundles. Closing.

Note: See TracTickets for help on using tickets.