Make a list of potential .onion errors

Let's make a list of all potential errors that can happen when visiting .onion services to help us design the corresponding error pages

Trac:
Parent Ticket: #19251 (moved)

added component::ux owner::antonela parent::19251 priority::medium resolution::implemented severity::normal sponsor::27-must status::closed type::task labels

Trac:
Parent: #30025 (moved) to #19251 (moved)

Trac:
Parent: #19251 (moved) to #19251 (moved)

https://github.com/torproject/torspec/blob/master/proposals/304-socks5-extending-hs-error-codes.txt

Hi! We have three ux challenges here:

1. how to inform the error to users
2. how we enable users to recover from that error if that is possible
3. how we encourage users to pick the safer path if an unsafe path is available

Ideally, this approach extends error management that could work in other clients and is not a specific feature for Tor Browser. The parent #30025 (moved) ticket will host Tor Browser specifics to this errors.

Proposal 304 has already some errors.

|Code | Type of Error | Error Page Copy | Recovery | Unsafe path | |-----|---------------|-----------------|----------|-------------|- |XF0 | Descriptor Can Not be Found | Onion Not Found| No | No | |XF1 | Descriptor Is Invalid | ? | Yes? | No | |XF2 | Introduction Failed | ? | ? | No | |XF3 | Rendezvous Failed | ? | Yes? | No |

Do we want to extend this list? Could you help me to fill the table?

Should we list #30022 (moved) typo errors here too? Do we want to support this feedback in Tor? Or is it something the client will figure out?

https://lists.torproject.org/pipermail/tor-dev/2019-September/014046.html

Trac:
Cc: gaba, antonela to gaba, antonela, brade, mcs

** Updated **

Code	Layer	Type of Error	Error Description	Title	Recovery	Unsafe path
XF0	service	Service Error	Service descriptor can not be found	Onion not Found	Maybe?	No
XF1	net	Network Error	Onion service Descriptor is Invalid	Network error	Yes - Reconnect	No
XF2	net	Network Error	Onion service Introduction Failed	Network error	Yes - Reconnect	No
XF3	net	Network Error	Onion service Rendezvous Failed	Network error	Yes - Reconnect	No
XF4	client	Client Error	Missing client authorization	Not Authorized	#30237 (moved)	No
XF5	client	Client Error	Wrong client authorization	Incorrect Key	#30237 (moved)	No
XF6	client	Client Error	Invalid checksum, public key, or encoding	Bad Address	No	No
XF7

R.e. comment:9, for 0xF4 there is recovery and it is the same as for 0xF5: the #30237 (moved) implementation will prompt. An improvement to our prompt would be to distinguish between these two situations; the current patches do not. For example, we could add extra text in the 0xF5 case such as "Incorrect key."

Also, the last line in the table should be updated to match the tor implementation (see #32546 (moved)). 0xF6 is "Bad address."

Also, 0xF2 and 0xF3 could be caused by a network problem or a service problem (at least that is how I read asn's message). Thinking about the proposal in ticket:19251#comment:6, does that mean that we don't know where to place the blame for the failure (network or service)?

Replying to mcs:

Also, 0xF2 and 0xF3 could be caused by a network problem or a service problem (at least that is how I read asn's message). Thinking about the proposal in ticket:19251#comment:6, does that mean that we don't know where to place the blame for the failure (network or service)?

And now I see that asn made essentially this same comment in ticket:19251#comment:8. Sorry for the redundant comment.

Thanks for the review! I updated #comment:9. For 0xF2 and 0xF3, maybe we can mark both network and service with an X? What'd you suggest?

Replying to antonela:

Thanks for the review! I updated #comment:9. For 0xF2 and 0xF3, maybe we can mark both network and service with an X? What'd you suggest?

My suggestion would be to mark both network and service with an "?"

There may be better solutions though

Since this ticket is about listing all errors and it seems like we have done that, can we close this ticket now and continue discussion about the error page behaviour in #19251 (moved) ?

The list of errors we are going to work with is defined. I think we can close this ticket after the proper specs are added to the regular documentation.

Is this up to date? is this the place where we should document these errors? https://github.com/torproject/torspec/blob/master/proposals/304-socks5-extending-hs-error-codes.txt

We are done here. Implementation is happening in the parent.

Trac:
Resolution: N/A to implemented
Status: new to closed

closed

mentioned in issue #33035 (moved)

mentioned in issue tpo/applications/tor-browser#33035 (closed)