Opened 14 months ago

Closed 4 months ago

#30090 closed task (implemented)

Make a list of potential .onion errors

Reported by: pili Owned by: antonela
Priority: Medium Milestone:
Component: UX Version:
Severity: Normal Keywords:
Cc: gaba, antonela, brade, mcs Actual Points:
Parent ID: #19251 Points:
Reviewer: Sponsor: Sponsor27-must

Description

Let's make a list of all potential errors that can happen when visiting .onion services to help us design the corresponding error pages

Child Tickets

Change History (16)

comment:1 Changed 9 months ago by pili

Parent ID: #30025#19251

comment:3 Changed 9 months ago by antonela

comment:5 Changed 8 months ago by antonela

Hi! We have three ux challenges here:

  1. how to inform the error to users
  2. how we enable users to recover from that error if that is possible
  3. how we encourage users to pick the safer path if an unsafe path is available

Ideally, this approach extends error management that could work in other clients and is not a specific feature for Tor Browser. The parent #30025 ticket will host Tor Browser specifics to this errors.

Proposal 304 has already some errors.

Code Type of Error Error Page Copy Recovery Unsafe path
XF0 Descriptor Can Not be Found Onion Not Found No No
XF1 Descriptor Is Invalid ? Yes? No
XF2 Introduction Failed ? ? No
XF3 Rendezvous Failed ? Yes? No

Do we want to extend this list? Could you help me to fill the table?

comment:6 Changed 8 months ago by antonela

Should we list #30022 typo errors here too? Do we want to support this feedback in Tor? Or is it something the client will figure out?

comment:8 Changed 8 months ago by mcs

Cc: brade mcs added

comment:9 Changed 8 months ago by antonela

Updated

Code Layer Type of Error Error Description Title Recovery Unsafe path
XF0 service Service Error Service descriptor can not be found Onion not Found Maybe? No
XF1 net Network Error Onion service Descriptor is Invalid Network error Yes - Reconnect No
XF2 net Network Error Onion service Introduction Failed Network error Yes - Reconnect No
XF3 net Network Error Onion service Rendezvous Failed Network error Yes - Reconnect No
XF4 client Client Error Missing client authorization Not Authorized #30237 No
XF5 client Client Error Wrong client authorization Incorrect Key #30237 No
XF6 client Client Error Invalid checksum, public key, or encoding Bad Address No No
XF7
Last edited 4 months ago by pili (previous) (diff)

comment:10 Changed 5 months ago by mcs

R.e. comment:9, for 0xF4 there is recovery and it is the same as for 0xF5: the #30237 implementation will prompt. An improvement to our prompt would be to distinguish between these two situations; the current patches do not. For example, we could add extra text in the 0xF5 case such as "Incorrect key."

Also, the last line in the table should be updated to match the tor implementation (see #32546). 0xF6 is "Bad address."

comment:11 Changed 5 months ago by mcs

Also, 0xF2 and 0xF3 could be caused by a network problem or a service problem (at least that is how I read asn's message). Thinking about the proposal in ticket:19251#comment:6, does that mean that we don't know where to place the blame for the failure (network or service)?

comment:12 in reply to:  11 Changed 5 months ago by mcs

Replying to mcs:

Also, 0xF2 and 0xF3 could be caused by a network problem or a service problem (at least that is how I read asn's message). Thinking about the proposal in ticket:19251#comment:6, does that mean that we don't know where to place the blame for the failure (network or service)?

And now I see that asn made essentially this same comment in ticket:19251#comment:8. Sorry for the redundant comment.

comment:13 Changed 5 months ago by antonela

Thanks for the review! I updated #comment:9. For 0xF2 and 0xF3, maybe we can mark both network and service with an X? What'd you suggest?

comment:14 in reply to:  13 Changed 5 months ago by pili

Replying to antonela:

Thanks for the review! I updated #comment:9. For 0xF2 and 0xF3, maybe we can mark both network and service with an X? What'd you suggest?

My suggestion would be to mark both network and service with an "?"

There may be better solutions though

comment:15 Changed 5 months ago by pili

Since this ticket is about listing all errors and it seems like we have done that, can we close this ticket now and continue discussion about the error page behaviour in #19251 ?

comment:16 Changed 4 months ago by antonela

The list of errors we are going to work with is defined. I think we can close this ticket after the proper specs are added to the regular documentation.

Is this up to date? is this the place where we should document these errors?
https://github.com/torproject/torspec/blob/master/proposals/304-socks5-extending-hs-error-codes.txt

comment:17 Changed 4 months ago by antonela

Resolution: implemented
Status: newclosed

We are done here. Implementation is happening in the parent.

Note: See TracTickets for help on using tickets.