Opened 12 days ago

Last modified 3 days ago

#30091 needs_review enhancement

Unify parsing code for control.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 3
Parent ID: #29210 Points: 3
Reviewer: catalyst Sponsor: Sponsor31-can

Description


Child Tickets

Change History (6)

comment:1 Changed 12 days ago by nickm

I have a WIP branch as control_command_refactor; there are a few more tests and commands to go.

comment:2 Changed 11 days ago by nickm

Sponsor: Sponsor31-can
Status: assignedneeds_review
Type: defectenhancement

Now it handles all the commands, and 'test-stem' passes. PR at https://github.com/torproject/tor/pull/919

comment:3 Changed 11 days ago by nickm

Actual Points: 3

comment:4 Changed 8 days ago by nickm

Per request from catalyst, I have rebased the branch as control_command_refactor_v2 and created a PR at https://github.com/torproject/tor/pull/940 .

comment:5 Changed 5 days ago by asn

Reviewer: catalyst

comment:6 Changed 3 days ago by catalyst

So far, I looked at

d1f5957c4e Improve handling of controller commands

through

e3fcbffbb8 Use parsing code for the simpler controller commands.

These look good. I commented on the pull request about a few technical debt issues and some minor spelling and naming things.

This set of commits seems to form a logical grouping and they could probably have been in their own child ticket/PR.

Note: See TracTickets for help on using tickets.