Opened 6 weeks ago

Closed 6 weeks ago

#30104 closed defect (fixed)

browser onboarding: 8.5 security level image includes English text

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-onboarding, tbb-8.5, ux-team, TorBrowserTeam20190410R
Cc: antonela Actual Points:
Parent ID: #25658 Points:
Reviewer: Sponsor:

Description

The security level image that is shown on the "updated for Tor Browser 8.5" Security onboarding page includes a screenshot of the Security Level doorhanger that was taken when running in the en-US locale. That means we will show English text for all locales. We should find a different solution in the long run.

This is the image: https://gitweb.torproject.org/tor-browser.git/plain/browser/extensions/onboarding/content/img/figure_tor-security-level.png?h=tor-browser-60.6.1esr-8.5-1

Child Tickets

Attachments (2)

security-level.png (42.4 KB) - added by antonela 6 weeks ago.
security-level-@1x.png (10.6 KB) - added by antonela 6 weeks ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 weeks ago by gk

Cc: antonela added
Keywords: tbb-8.5 ux-team added

While I agree this is not urgent for the alpha, it would be swell to have this fixed in 8.5 if that's possible. Putting it on that radar.

comment:2 Changed 6 weeks ago by gk

Parent ID: #25658

Changed 6 weeks ago by antonela

Attachment: security-level.png added

comment:3 Changed 6 weeks ago by antonela

Good catch. I attached a solution for all the locales. We can replace the English one too. What do you think?

comment:4 in reply to:  3 Changed 6 weeks ago by mcs

Replying to antonela:

Good catch. I attached a solution for all the locales. We can replace the English one too. What do you think?

Thanks for the quick response! I think this is a good solution. It would be best if you gave us a @1X image (300 x 300 pixels) since currently we cannot use @2x or @3x images (due to #27357).

Changed 6 weeks ago by antonela

Attachment: security-level-@1x.png added

comment:6 Changed 6 weeks ago by mcs

Keywords: TorBrowserTeam20190410R added
Status: newneeds_review

comment:7 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Pushed to tor-browser-60.6.1esr-8.5-1 (commit d8163c5fe45122f4e7fa98b77e37a5736421edb9) with a slightly modified commit message (pointing to this ticket being fixes (as well)).

Note: See TracTickets for help on using tickets.