Opened 5 months ago

Closed 5 months ago

#30109 closed defect (fixed)

Document that MapAddress is automatically strict, but does not handle redirects

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.8
Severity: Normal Keywords: easy, doc, security-low, tor-client, tor-exit, 040-backport
Cc: Actual Points: 0.3
Parent ID: #29989 Points: 0.1
Reviewer: mikeperry Sponsor:

Description (last modified by teor)

We should document that:

  1. StrictNodes does not apply to MapAddress
  2. MapAddress falls back to a random exit by default fails rather than falling back to a random exit

Edited to add:

  1. If the site does a redirect, MapAddress does not apply to the new site

Child Tickets

Change History (7)

comment:1 Changed 5 months ago by arma

"1" is true, and I believe "2" is false.

comment:2 in reply to:  1 Changed 5 months ago by teor

Description: modified (diff)
Keywords: security-low added; security-low? removed
Summary: Document that there is no StrictNodes for MapAddressDocument that MapAddress is automatically strict, but does not handle redirects

Replying to arma:

"1" is true, and I believe "2" is false.

Yes, I think you're right, from reading the code.

Unfortunately I can't reproduce the issues in #29989, but I think they might have been due to a redirect.

comment:3 Changed 5 months ago by teor

Actual Points: 0.3
Status: newneeds_review

comment:4 Changed 5 months ago by teor

Keywords: 040-backport added
Milestone: Tor: unspecifiedTor: 0.4.0.x-final

We can merge this doc fix into 0.4.0 if we'd like

comment:5 Changed 5 months ago by asn

Reviewer: mikeperry

comment:6 Changed 5 months ago by mikeperry

Status: needs_reviewmerge_ready

Wow, whatever dark curse prevents MapAddress from applying if there was a redirect seems like a bug, and a very strange one.. But at least it's documented now. This looks good.

comment:7 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master; not planning to backport.

Note: See TracTickets for help on using tickets.