Opened 2 months ago

Closed 8 weeks ago

#30112 closed defect (fixed)

Fix outdated comments in dirserv_read_measured_bandwidths()

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: doc, comment, technical-debt, tor-bwauth
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: mikeperry Sponsor:

Description

We refactored the function to use tor_getdelim(), but didn't remove the comments about fgets().

Child Tickets

Change History (4)

comment:1 Changed 2 months ago by teor

Keywords: technical-debt tor-bwauth added
Status: assignedneeds_review

See my pull request:
https://github.com/torproject/tor/pull/922

I don't think there is much point in backporting these comments to 0.4.0.

comment:2 Changed 2 months ago by asn

Reviewer: mikeperry

comment:3 Changed 8 weeks ago by mikeperry

Status: needs_reviewmerge_ready

Yay updated comments. Looks good.

comment:4 Changed 8 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Thanks for the review; merged to master.

Note: See TracTickets for help on using tickets.