Opened 6 months ago

Closed 6 months ago

#30119 closed defect (fixed)

cert-spec uses binary encodings but does not specify byte order

Reported by: irl Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: dir-spec, easy, doc, fast-fix
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

From looking at the Tor implementation (in a black box way, didn't look at the source code) these seem to be big endian byte order. We should have a note in cert-spec for implementors so they don't have to guess.

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by irl

Keywords: dir-spec added

comment:2 Changed 6 months ago by teor

Keywords: easy doc fast-fix added
Milestone: Tor: unspecified
Points: 0.1

We have a similar note in tor-spec.txt, which we could copy across.
(I'm not sure if cert-spec.txt was ever part of tor-spec.txt.)

comment:3 Changed 6 months ago by nickm

It's fine to copy the notice, or to add it by reference.

comment:4 Changed 6 months ago by rl1987

Status: newneeds_review

comment:5 Changed 6 months ago by asn

Reviewer: nickm

comment:6 Changed 6 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged!

Note: See TracTickets for help on using tickets.