Opened 6 weeks ago

Closed 4 weeks ago

#30120 closed defect (fixed)

pre-commit.git-hook doesn't check for changes files correctly.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: git-scripts shell dgoulet-merge
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: ahf Sponsor:

Description

Have a look. What's wrong here:

-if [ ! -z "ls ./changes/*" ]; then

Child Tickets

Change History (6)

comment:1 Changed 6 weeks ago by nickm

Status: assignedneeds_review

See branch bug30120 with PR at https://github.com/torproject/tor/pull/930

comment:2 Changed 5 weeks ago by asn

Reviewer: ahf

comment:3 Changed 5 weeks ago by ahf

Status: needs_reviewmerge_ready

Oops, good catch.

comment:4 Changed 5 weeks ago by nickm

Keywords: git-scripts shell dgoulet-merge added

comment:5 Changed 5 weeks ago by nickm

Actual Points: 0

comment:6 Changed 4 weeks ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.