Opened 19 months ago

Last modified 5 months ago

#30123 assigned defect

MAPADDRESS result can mix status codes

Reported by: catalyst Owned by: neel
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: tor-control, tor-spec
Cc: neel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When using MAPADDRESS at the control port, mixing valid and invalid address mappings can result in a mixture of status codes, contrary to Section 2.3, which says:

  Multiple lines in a single reply from Tor to the controller are guaranteed to
  share the same status code.


mapaddress xxx=@@@
512-syntax error: invalid address '@@@'

It's not clear what the right thing to do here is. Checking the syntax first might help, but maybe it's possible to run into resource exhaustion for some requested mappings and not others?

Child Tickets

Change History (2)

comment:1 Changed 19 months ago by nickm

Hm. My first thought is that it is indeed possible for this to succeed in part but fail in part. Let's amend the specification so that it says "unless documented otherwise", and then document that MAPADDRESS does this.

comment:2 Changed 5 months ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned
Note: See TracTickets for help on using tickets.