Decide whether to use "Tor Browser" or "Tor Browser for Android" for mobile stable

In #28622 (moved) the question came up whether we should use "Tor Browser" or "Tor Browser for Android" for mobile. I think the former as Android is yet another platform besides Windows, macOS, and Linux. We only have one browser that serves all the platforms.

added GeorgKoppen201904 TorBrowserTeam201905R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-8.5-must tbb-mobile tbb-parity type::defect labels

Adding emmapeel as this might affect translations/translators.

Trac:
Cc: steph, sysrqb to steph, sysrqb, emmapeel

I think "Tor Browser" makes sense, matching with other platforms. We will still mention for Android where appropriate in promotions.

Replying to steph:

I think "Tor Browser" makes sense, matching with other platforms. We will still mention for Android where appropriate in promotions.

Makes sense, thanks.

Trac:
Keywords: N/A deleted, GeorgKoppen201904 added

bug_30136 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_30136&id=4d8409b3689d6def15540e766c3df2a2919023a2) in my `tor-browser repo has the changes for review.

Trac:
Keywords: TorBrowserTeam201904 deleted, TorBrowserTeam201904R added
Status: new to needs_review

"Tor Browser" is valid for all other platform. make it "Tor Browser" on mobile too

lgtm. I'll build them tomorrow.

No April anymore, moving review tickets to May.

Trac:
Keywords: TorBrowserTeam201904R deleted, TorBrowserTeam201905R added

These look good, but I noticed another bug we should fix (probably a fixup for #28622 (moved)). When I built with official branding, I see the about:firefox favicon is using the alpha icon (blue-ish), instead of the official icon (purple-ish). I'm rebuilding now to confirm this wasn't caused by something else.

Replying to sysrqb:

These look good, but I noticed another bug we should fix (probably a fixup for #28622 (moved)). When I built with official branding, I see the about:firefox favicon is using the alpha icon (blue-ish), instead of the official icon (purple-ish). I'm rebuilding now to confirm this wasn't caused by something else.

Hm, how did the rebuild go? Do you still see the issue? If so, could you attach a screenshot showing the problem? I double-checked the assets in mobile/branding/official (which should get used by the stable build) and did not find any alpha related icon.

Replying to gk:

Replying to sysrqb:

These look good, but I noticed another bug we should fix (probably a fixup for #28622 (moved)). When I built with official branding, I see the about:firefox favicon is using the alpha icon (blue-ish), instead of the official icon (purple-ish). I'm rebuilding now to confirm this wasn't caused by something else.

Hm, how did the rebuild go? Do you still see the issue? If so, could you attach a screenshot showing the problem? I double-checked the assets in mobile/branding/official (which should get used by the stable build) and did not find any alpha related icon.

Whoops! I forgot to update this. The rebuild was good, I'm guessing this was caused by some artifact. I think this is ready.

Trac:
Status: needs_review to merge_ready

Fixed with commit 3d5e5cc086f443c5ab5a0125a174d3e5f50181a2 on tor-browser-60.6.1esr-8.5-1, thanks.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#30136 (closed)