Opened 5 months ago

Closed 6 weeks ago

#30148 closed defect (fixed)

Fix infrequent, unlikely memory leak on failure to create keys directory

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-no-backport 035-backport 040-backport
Cc: Actual Points: 0
Parent ID: #30146 Points: 0
Reviewer: mikeperry Sponsor:

Description

In load_ed_keys(), if we can't create the key directory, we leak some memory.

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by nickm

Keywords: 034-backport 035-backport 040-backport added
Status: assignedneeds_review

See branch ticket30148_034 with PR at https://github.com/torproject/tor/pull/937.

I don't recommend backporting this any farther than 0.3.5; it is trivial and 0.3.4 is approaching end of life.

comment:2 Changed 5 months ago by asn

Reviewer: mikeperry

comment:3 Changed 5 months ago by mikeperry

Status: needs_reviewmerge_ready

This is very simple and looks good to me; sorry for the delay.

comment:4 Changed 5 months ago by nickm

Keywords: asn-merge added

comment:5 Changed 5 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged.

comment:6 Changed 4 months ago by teor

Keywords: 034-no-backport added; 034-backport removed
Resolution: fixed
Status: closedreopened

Looks like we missed this backport.

comment:7 Changed 4 months ago by teor

Milestone: Tor: 0.4.1.x-finalTor: 0.4.0.x-final
Status: reopenedmerge_ready

comment:8 Changed 3 months ago by asn

Keywords: asn-merge removed

comment:9 Changed 6 weeks ago by teor

Actual Points: 0
Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final
Points: 0
Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.5.
Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

Note: See TracTickets for help on using tickets.