Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#30151 closed defect (fixed)

Fix memory leak in tor-resolve

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 040-no-backport dgoulet-merge
Cc: Actual Points:
Parent ID: #30146 Points:
Reviewer: catalyst Sponsor:

Description

Coverity found a memory leak in tor-resolve. There's no actual problem here, since the program exits anyway, but we try to fix coverity warnings on principle.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by nickm

Keywords: 040-backport?? added
Status: assignedneeds_review

See branch bug30151_040 with PR at https://github.com/torproject/tor/pull/939 .

I don't actually know whether we should backport this; a memory leak here is totally harmless. Then again, so is the fix.

comment:2 Changed 5 months ago by asn

Reviewer: catalyst

comment:3 in reply to:  1 Changed 5 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

See branch bug30151_040 with PR at https://github.com/torproject/tor/pull/939 .

I don't actually know whether we should backport this; a memory leak here is totally harmless. Then again, so is the fix.

Thanks! Looks good!

I have no opinion on whether or not to backport.

comment:4 Changed 5 months ago by nickm

Keywords: dgoulet-merge added

comment:5 Changed 5 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

comment:6 Changed 4 months ago by teor

Keywords: 040-no-backport added; 040-backport?? removed

I don't think we need to backport this change.

Note: See TracTickets for help on using tickets.