ALL_BUGS_ARE_FATAL build failures in 0.3.4 and later.

Found while reviewing #30179 (moved):

We don't include stdlib.h in util_bugs.h, which is sometimes a problem, since the macros declared there can call abort().

This problem is particularly bad for the nonfatal assertions, since they don't call abort() unless ALL_BUGS_ARE_FATAL is defined, which it only rarely is.

changed milestone to %Tor: 0.3.5.x-final

added 035-backport actualpoints::.1 component::core tor/tor milestone::Tor: 0.3.5.x-final owner::nickm points::.1 priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed type::defect labels

Branch bug30189_035; PR is https://github.com/torproject/tor/pull/952

Trac:
Component: - Select a component to Core Tor/Tor
Status: assigned to needs_review
Actualpoints: N/A to .1

There's a merge conflict with master, resolved in bug30189_041 with PR at https://github.com/torproject/tor/pull/953

I recommend no backport to 0.3.4, since this is a pretty rare configuration for anybody to build in.

(Note that master will still be broken with ALL_BUGS_ARE_FATAL until #30179 (moved) is merged on top of this)

Should we add ALL_BUGS_ARE_FATAL to one of our CI jobs?

On the one hand it might be worthwhile, but on the other hand it's not actually a configuration we recommend for anything but stress-testing, fuzzing, and the like.

Trac:
Reviewer: N/A to dgoulet

Trac:
Status: needs_review to merge_ready

Let's merge this in 0.4.1 only for now and plan a backport: it isn't a configuration we support very much.

Trac:
Keywords: 035-backport deleted, 035-backport asn-merge added

Merged in master. Keeping it open.

Trac:
Keywords: 035-backport asn-merge deleted, 035-backport added

Backported to 0.4.0

Trac:
Milestone: Tor: 0.4.0.x-final to Tor: 0.3.5.x-final

Backported to 0.3.5. Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed
Points: N/A to .1

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#30189 (closed)