Opened 5 months ago

Closed 6 weeks ago

#30189 closed defect (fixed)

ALL_BUGS_ARE_FATAL build failures in 0.3.4 and later.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: dgoulet Sponsor:

Description

Found while reviewing #30179:

We don't include stdlib.h in util_bugs.h, which is sometimes a problem, since the macros declared there can call abort().

This problem is particularly bad for the nonfatal assertions, since they don't call abort() unless ALL_BUGS_ARE_FATAL is defined, which it only rarely is.

Child Tickets

Change History (11)

comment:1 Changed 5 months ago by nickm

Actual Points: .1
Component: - Select a componentCore Tor/Tor
Status: assignedneeds_review
Last edited 5 months ago by nickm (previous) (diff)

comment:2 Changed 5 months ago by nickm

There's a merge conflict with master, resolved in bug30189_041 with PR at https://github.com/torproject/tor/pull/953

I recommend no backport to 0.3.4, since this is a pretty rare configuration for anybody to build in.

comment:3 Changed 5 months ago by nickm

(Note that master will still be broken with ALL_BUGS_ARE_FATAL until #30179 is merged on top of this)

comment:4 Changed 5 months ago by teor

Should we add ALL_BUGS_ARE_FATAL to one of our CI jobs?

comment:5 Changed 5 months ago by nickm

On the one hand it might be worthwhile, but on the other hand it's not actually a configuration we recommend for anything but stress-testing, fuzzing, and the like.

comment:6 Changed 5 months ago by asn

Reviewer: dgoulet

comment:7 Changed 5 months ago by dgoulet

Status: needs_reviewmerge_ready

comment:8 Changed 5 months ago by nickm

Keywords: asn-merge added

Let's merge this in 0.4.1 only for now and plan a backport: it isn't a configuration we support very much.

comment:9 Changed 5 months ago by asn

Keywords: asn-merge removed

Merged in master. Keeping it open.

comment:10 Changed 4 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

Backported to 0.4.0

comment:11 Changed 6 weeks ago by teor

Points: .1
Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.5.
Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

Note: See TracTickets for help on using tickets.