Opened 6 weeks ago

Last modified 3 weeks ago

#30199 new defect

tor-android-service: Review 2019/04/16

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-8.5, TorBrowserTeam201905
Cc: sisbell Actual Points:
Parent ID: #27609 Points:
Reviewer: Sponsor:

Description

Overall, nicely done. This review is on master (6a9314aff4418a4edac33ff39fae266b097cf000):

the initial import (36f9873ff075253f4c1c9e394c91031fd4ba9d4a), do you know the git hash of the orbot commit you used?

1d635a925ca1728542067ee7bf34ff532d623a3f - The renaming is Tor Browser specific, so we should probably carry this as a patch in tor-browser-build, instead of hard coding "Tor Browser" within a general purpose "Tor service" library, right?

45244c49fbe382e97655b8f8d8f482e54f95ed07 - I wonder if we should carry a patch for this too. If tor-android-services+TOPL is intended as a general Android Tor library, then we probably shouldn't make it Tor Browser specific.

f3b3df4e66630a68c9987d52d93580549a0acaf4 - this package doesn't exist yet, but it will exist in a few weeks, so leaving it is probably okay.

1a2121e2a7ee8a6c0f3b5edd150b38eaae8bef304 - hasCookieAuthentication() and runAsDaemon() seem out of place in this commit

784919d8eb19083cf761b3e7314c49d8befc00cd - custom tor, the binaries should be compiled as dependencies by tor-browser-build and injected into the build, TorService.TOR_VERSION should be patched at build time

6a9314aff4418a4edac33ff39fae266b097cf000 - In the future, we should take the bridges used on desktop (currently specified in Firefox's pref format and injected at build time by tor-browser-build), and pre-process them for inclusion on Android, too.

Child Tickets

Change History (4)

comment:1 Changed 6 weeks ago by sysrqb

Keywords: tbb-mobile tbb-8.5 TorBrowserTeam201904 added

comment:2 Changed 5 weeks ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed
Parent ID: #27609

comment:3 Changed 3 weeks ago by gk

Keywords: tbb-8.5 added; tbb-8.5-must removed

Nice to have but no blocker anymore.

comment:4 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201904 removed

Moving tickets to May

Note: See TracTickets for help on using tickets.