Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3020 closed defect (fixed)

Mismatched accounting interval: moved by 90.32% when no DST changed

Reported by: BarkerJr Owned by:
Priority: Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version: Tor: 0.2.2.22-alpha
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On #1511 BarkerJr said:

Mar 01 00:00:00.023 [warn] Mismatched accounting interval: moved by 90.32%. Starting a fresh one.
Mar 01 00:00:00.189 [info] reset_accounting(): Starting new accounting interval.

Not sure why, since DST has not changed.

Is this still happening? How often does it happen? Does it come with any more logs?

Child Tickets

Change History (9)

comment:1 Changed 8 years ago by nickm

There are better logs on #2003 , but more logs would be great.

comment:2 Changed 8 years ago by arma

Reporter: changed from arma to BarkerJr

comment:3 in reply to:  description Changed 8 years ago by BarkerJr

Didn't reoccur on April 1, 0.2.2.23-alpha.

comment:4 Changed 8 years ago by nickm

Hm. February is almost exactly 90.32% the length of march. That sounds like a clue.

comment:5 Changed 8 years ago by Sebastian

Status: newneeds_review

indeed it is.
The bug is in

    long duration = length_of_accounting_period_containing(now);
    double delta = ((double)(s_now - interval_start_time)) / duration;

I think.

I have an idea for a fix in branch bug3020 in my repository.

comment:6 Changed 8 years ago by arma

Sounds plausible to me

comment:7 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good to me too; merging it & closing this for now. let's reopen if this message reappears.

comment:8 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:9 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.