Opened 6 weeks ago

Last modified 4 weeks ago

#30213 merge_ready defect

Remove sudo: false from Travis

Reported by: teor Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, tor-ci 040-backport 035-backport 034-backport 029-backport
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: catalyst Sponsor:

Description

Travis has made all of its builders sudo: true, so we can remove the sudo block, and the exclude: sudo blocks.

Child Tickets

Change History (12)

comment:1 Changed 5 weeks ago by rl1987

I suppose this ticket is meant to follow Travis recommendations at [0]. However several build jobs disappeared when I tried to remove sudo: lines in exclude: block.

See my branch at: https://github.com/rl1987/tor/tree/ticket30213
Travis CI schedule for 62b9ed56040ef49bae32c285f78ba6fbc71f00d5, which removes both sudo: lines in exclude: block. : https://travis-ci.org/rl1987/tor/builds/522784122

Somethings seems to be amiss.

[0] https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

comment:2 Changed 5 weeks ago by teor

Status: newneeds_revision

Each rule is an array of match criteria, starting with "-".

These rules mean "exclude clang builds with no sudo" and "exclude gcc builds with sudo":

  exclude:
    ## Clang doesn't work in containerized builds, see below.
    - compiler: clang
      sudo: false
    ## Non-containerized gcc are slow and redundant.
    - compiler: gcc
      sudo: required
    ## gcc on OSX is less useful, because the default compiler is clang.
    - compiler: gcc
      os: osx

Your patch replaces them with: "exclude clang builds" and "exclude gcc builds" (and then you reverted one of those changes):

  exclude:
    ## Clang doesn't work in containerized builds, see below.
    - compiler: clang
    ## Non-containerized gcc are slow and redundant.
    - compiler: gcc
    ## gcc on OSX is less useful, because the default compiler is clang.
    - compiler: gcc
      os: osx

Instead, remove the entire rule, for every rule that mentions sudo:

  exclude:
    ## gcc on OSX is less useful, because the default compiler is clang.
    - compiler: gcc
      os: osx

comment:3 Changed 5 weeks ago by teor

Milestone: Tor: unspecifiedTor: 0.4.1.x-final

comment:4 Changed 5 weeks ago by rl1987

Owner: set to rl1987
Status: needs_revisionaccepted

comment:5 Changed 5 weeks ago by rl1987

Status: acceptedneeds_review

comment:6 Changed 4 weeks ago by dgoulet

Reviewer: catalyst

comment:7 in reply to:  5 Changed 4 weeks ago by catalyst

Status: needs_reviewneeds_revision

Replying to rl1987:

https://github.com/torproject/tor/pull/977

Thanks! Looks good.

I would feel better if there were a pull request for each supported release, though. wiki:org/teams/NetworkTeam/CoreTorReleases

Would you be willing to do that? Another team member might also be willing to do that when they have time.

comment:9 in reply to:  8 ; Changed 4 weeks ago by catalyst

Replying to rl1987:

Thanks! I needed to close and reopen a couple of them because Travis tried building them with the wrong config (because a few of the pull requests were incorrectly shown as based on master at the time Travis got them).

comment:10 in reply to:  9 ; Changed 4 weeks ago by catalyst

Replying to catalyst:

Thanks! I needed to close and reopen a couple of them because Travis tried building them with the wrong config (because a few of the pull requests were incorrectly shown as based on master at the time Travis got them).

Also I closed and reopened the other two, because Travis seems to have built them against the merge point with master.

comment:11 in reply to:  10 Changed 4 weeks ago by catalyst

Status: needs_reviewmerge_ready

Replying to catalyst:

Also I closed and reopened the other two, because Travis seems to have built them against the merge point with master.

These have completed.

comment:12 Changed 4 weeks ago by nickm

Keywords: 040-backport 035-backport 034-backport 029-backport added
Milestone: Tor: 0.4.1.x-finalTor: 0.4.0.x-final

Okay; I've merged this into master. Marking for backport.

Note: See TracTickets for help on using tickets.