TBA - NPE in ChangeOnionAlphaRunnable

java.lang.NullPointerException: 
  at org.mozilla.gecko.torbootstrap.TorBootstrapPanel$ChangeOnionAlphaRunnable.run (TorBootstrapPanel.java:77)
  at java.lang.Thread.run (Thread.java:784)

added TorBrowserTeam201905R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-8.5-must tbb-mobile type::defect labels

It seems like getActivity() is null here :(

 77                  getActivity().runOnUiThread(new Runnable() {                                                                                                                                                  
 78                       public void run() {
 79                           setOnionAlphaValue(newAlpha);
 80                       }
 81                  });

This doesn't seem likely during initial startup, but maybe this is triggering after selecting the Settings cog/gear? Maybe there's a race there?

Do you have steps to reproduce this one (as well)?

I don't have steps for reproducing it, but I think I have a branch that prevents it. This is only a guess, though. Branch 30214_00 in my repo.

I still think this is happening when the user presses the gear button after they started bootstrapping. This patch tries preventing the race condition where the background thread remains alive after the current activity becomes invalid.

Trac:
Status: new to needs_review

Hmm. I wonder if this is a duplicate of #29982 (moved).

Trac:
Keywords: TorBrowserTeam201904 deleted, TorBrowserTeam201905R added

Looks good to me. Let's see whether we are squashing #29982 (moved) here as well. Cherry-picked to tor-browser-60.6.1esr-8.5-1 as commit 7a0a10b8ff98ebfc53fa46fb3223af0f64a97964.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#30214 (closed)