Add the tor versions for bridge-distribution-request

dir-spec says it's not implemented, but it was implemented in 0.3.2.3-alpha and backported.

#18329 (moved) was Sponsor M, but the relevant current sponsor is Sponsor 19.

changed milestone to %Tor: 0.4.1.x-final

added actualpoints::0.2 component::core tor/tor fast-fix milestone::Tor: 0.4.1.x-final owner::teor points::0.1 priority::medium resolution::implemented reviewer::catalyst severity::normal sponsor::19-can status::closed tor-spec type::defect labels

https://github.com/torproject/torspec/pull/77

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to catalyst

The text of the changes looks good. It would be great if someone who knew the relevant history could fact-check the change. (I think I don't know enough to do so without possibly extensive research.)

Here's how I found the feature version in tor:

$ git log -S bridge-distribution-request --reverse
commit ebab521525
Author: Roger Dingledine <arma@torproject.org>
Date:   Sun Nov 13 02:39:16 2016 -0500

    Add new BridgeDistribution config option
    
    Bridge relays can use it to add a "bridge-distribution-request" line
    to their bridge descriptor, which tells BridgeDB how they'd like their
    bridge address to be given out.
    
    Implements tickets 18329.
...
$ git describe --contains ebab521525
tor-0.3.2.3-alpha~15^2~4

And here's how I found the backport versions:

$ git log tp/maint-0.3.1 -S bridge-distribution-request --reverse
commit 9f2efd02a1 (nickm/ticket18329_minimal_025)
Author: Nick Mathewson <nickm@torproject.org>
Date:   Mon Nov 13 20:44:51 2017 -0500

    Minimal implementation of bridge-distribution-request
    
    Just advertise the line when we're a bridge, using "any" if we're
    published or "none" if we aren't.
    
    This is done in lieu of a full backport of #18329.
$ git tag --contains 9f2efd02a1 | sort -V
tor-0.2.5.16
tor-0.2.8.17
tor-0.2.9.14
tor-0.2.9.15
tor-0.2.9.16
tor-0.2.9.17
tor-0.3.0.13
tor-0.3.1.9
tor-0.3.1.10
tor-0.3.2.5-alpha
...

I didn't use sort -V when I was writing the patch, so I got the 0.3.1 backport version wrong. I pushed a commit that changes the version to 0.3.1.9.

Trac:
Actualpoints: 0.1 to 0.2

Replying to teor:

Here's how I found the feature version in tor: Thanks! I've confirmed this.

Trac:
Status: needs_review to merge_ready

Thanks for the patch and the review! I've merged this to torspec.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 48m

added 1h 36m of time spent

moved to tpo/core/tor#30224 (closed)