Opened 3 months ago

Closed 2 months ago

#30236 closed defect (fixed)

Encapsulate details about crypt_path_t data structure

Reported by: asn Owned by: asn
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt refactoring dgoulet-merge
Cc: Actual Points:
Parent ID: #29209 Points:
Reviewer: nickm Sponsor: Sponsor31-can

Child Tickets

Change History (11)

comment:2 Changed 3 months ago by asn

Description: modified (diff)

comment:3 Changed 3 months ago by nickm

asn's code is at ​https://github.com/torproject/tor/pull/982 . I like it; I'll squash it and give it another chance to build, then pass it to dgoulet to merge.

comment:4 Changed 3 months ago by nickm

Status: newmerge_ready

Squashed as asn_ticket30236_squashed; merged as asn_ticket30236_squashed_merged. PR at https://github.com/torproject/tor/pull/996

If CI passes, let's take it!

comment:5 Changed 3 months ago by nickm

(test-stem failed but I doubt it is related. restarted that travis job.)

comment:6 Changed 3 months ago by nickm

Keywords: dgoulet-merge added

comment:7 Changed 3 months ago by nickm

Owner: set to asn
Status: merge_readyassigned

Setting owner

comment:8 Changed 3 months ago by nickm

Reviewer: nickm
Status: assignedmerge_ready

comment:9 Changed 3 months ago by nickm

Sponsor: Sponsor31-can

comment:10 Changed 3 months ago by dgoulet

Status: merge_readyneeds_revision

Some conflicts with master because of #26288. Doesn't look complicated, just I would like a review on it thus I'm not fixing it myself.

Thanks!

comment:11 Changed 3 months ago by asn

Status: needs_revisionmerge_ready

comment:12 Changed 2 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.