Opened 4 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#30263 closed defect (fixed)

make shellcheck expects scripts in the build directory

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.4.0.1-alpha
Severity: Normal Keywords: shellcheck, 040-backport, 040-must, tor-ci-might-fail-on-upgrade, regression
Cc: rl1987 Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor: Sponsor31-can

Description

In #28058, we added shellcheck for coverage and cov-diff. But we expect coverage to be in the build directory, which is wrong.

This fails the newest version of shellcheck in out-of-tree builds.

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by teor

Actual Points: 0.1
Status: newneeds_review

comment:2 Changed 3 weeks ago by dgoulet

Status: needs_reviewmerge_ready

ACK.

comment:3 Changed 3 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to 0.4.0 and forward

comment:4 Changed 3 weeks ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.0.x-final
Note: See TracTickets for help on using tickets.