Opened 8 months ago
Closed 3 months ago
#30279 closed enhancement (fixed)
Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor stable supports them
Reported by: | teor | Owned by: | teor |
---|---|---|---|
Priority: | Low | Milestone: | |
Component: | Core Tor/Chutney | Version: | |
Severity: | Normal | Keywords: | merge-after-041-stable-in-homebrew, tor-hs, ipv6, single-onion, fast-fix, chutney-ci, network-team-roadmap-2019-Q1Q2, 041-deferred-20190530 |
Cc: | teor | Actual Points: | 0.2 |
Parent ID: | Points: | 0.1 | |
Reviewer: | nickm | Sponsor: | Sponsor19-can |
Description
When #23588 merges, we should replace single-onion-ipv6-md with single-onion-v23-ipv6-md in Chutney's CI.
Child Tickets
Change History (17)
comment:1 Changed 8 months ago by
Actual Points: | → 0.1 |
---|---|
Keywords: | tor-hs ipv6 single-onion added |
Status: | assigned → needs_review |
comment:3 Changed 6 months ago by
Keywords: | 041-deferred-20190530 added |
---|
Marking these tickets as deferred from 041.
comment:4 Changed 6 months ago by
Milestone: | Tor: 0.4.1.x-final → Tor: 0.4.2.x-final |
---|
comment:6 Changed 6 months ago by
Actual Points: | 0.1 → 0.2 |
---|---|
Keywords: | merge-after-041-stable-in-homebrew added |
Milestone: | Tor: 0.4.2.x-final |
Parent ID: | #29729 |
Whoops, I merged this to master as f90f8e4, but then reverted it as 601a3b9.
This merge will have to wait for 0.4.1-stable, because:
- we can only do IPv6 on macOS on Travis,
- macOS Travis uses homebrew, which tracks tor stable,
- #23588 was merged into 0.4.1.1-alpha.
I re-did the branch based on #30820, because there were conflicts. (And #30820 can merge as soon as it is reviewed.)
comment:8 Changed 6 months ago by
Looks good to me, but we shouldn't merge it till homebrew updates.
comment:9 Changed 6 months ago by
Summary: | Test IPv6-only v3 onion services in Chutney's CI, once tor master supports them → Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor stable supports them |
---|
comment:10 follow-up: 11 Changed 4 months ago by
We could revisit this once we merge #30827 and add 041-nightly to Chutney's travis.
comment:11 Changed 4 months ago by
Replying to nickm:
We could revisit this once we merge #30827 and add 041-nightly to Chutney's travis.
Yeah, we might need to revise the patch again.
But the merge will have to wait for 0.4.1-stable in Homebrew:
Replying to teor:
This merge will have to wait for 0.4.1-stable, because:
- we can only do IPv6 on macOS on Travis,
- macOS Travis uses homebrew, which tracks tor stable,
- #23588 was merged into 0.4.1.1-alpha.
comment:12 Changed 4 months ago by
Status: | needs_review → merge_ready |
---|
Homebrew now includes 0.4.1.5 -- I've restarted travis on the PR. Let's merge it if it passes.
comment:13 Changed 4 months ago by
Status: | merge_ready → needs_revision |
---|
The version of Tor in the homebrew cache in the Travis image is 0.3.3.7:
$ tor --version Tor version 0.3.3.7 (git-035a35178c92da94).
We don't have any integration tests for this code right now, so it's probably worth refreshing the homebrew cache just for this job.
comment:14 Changed 4 months ago by
(Alternately, we could add a macOS chutney job to Tor's CI, and that would test Tor master. We should probably do both.)
comment:15 Changed 3 months ago by
Status: | needs_revision → merge_ready |
---|
I added a homebrew update, let's see if CI passes.
comment:16 Changed 3 months ago by
I'll merge this as soon as CI passes, and CI on #31639 fails. (We expect it to fail.)
comment:17 Changed 3 months ago by
Resolution: | → fixed |
---|---|
Status: | merge_ready → closed |
Merged to master as 33cbff7.
See:
Which is based on #29729. (We might want to rebase on master after merging #29729.)
The CI on this branch will fail until #23588 is merged into tor master, and built into a nightly binary.