Opened 8 years ago

Last modified 7 months ago

#3029 new enhancement

We should save received documents before parsing them

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: lorax, tor-dirauth, debugging, diagnostic, tor-dos
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:

Description

We should have an option to make Tor save every document it receives from the network before it tries to parse it. That way, if we crash while we're handling the document, we can know what crashed us.

Also, everything that stores an unparseable/unreadable thingy should be able to save more than one of them.

Child Tickets

Change History (18)

comment:1 Changed 8 years ago by nickm

Type: defectenhancement

comment:2 Changed 8 years ago by nickm

Most of this was suggested by rransom at #2683 .

comment:3 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

We should still do this. But it isn't going to make the 0.2.3.x merge window

comment:4 Changed 6 years ago by nickm

Keywords: tor-auth added

comment:5 Changed 6 years ago by nickm

Component: Tor Directory AuthorityTor

comment:6 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:7 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:8 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These may be worth looking at for 0.2.7.

comment:9 Changed 4 years ago by nickm

Status: newassigned

comment:10 Changed 4 years ago by nickm

Keywords: lorax added
Milestone: Tor: 0.2.7.x-finalTor: unspecified

This hasn't been so much of an urgent issue since we started improving our testing infrastructure; deferring from 0.2.7

comment:11 Changed 4 years ago by rl1987

Owner: set to rl1987
Status: assignedaccepted

comment:12 Changed 19 months ago by dgoulet

Keywords: tor-dirauth added; tor-auth removed

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

comment:13 Changed 19 months ago by nickm

Keywords: dos debugging diagnostic added
Points: 3
Severity: Normal

comment:14 Changed 19 months ago by arma

I am much more excited about the ticket where we check signatures before doing the parsing. :)

(I think that's #1299.)

comment:15 Changed 10 months ago by dgoulet

Keywords: tor-dos added; dos removed

Rename keyword "dos" to "tor-dos"

comment:16 Changed 8 months ago by rl1987

Status: acceptednew

comment:17 Changed 7 months ago by rl1987

Owner: rl1987 deleted
Status: newassigned

comment:18 Changed 7 months ago by rl1987

Status: assignednew
Note: See TracTickets for help on using tickets.