Opened 5 weeks ago

Closed 4 weeks ago

#30293 closed defect (fixed)

Refactor periodic event system so mainloop doesn't necessarily own everything.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: dgoulet Actual Points: .5
Parent ID: #30292 Points: .5
Reviewer: dgoulet Sponsor: Sponsor31-can

Description


Child Tickets

Change History (7)

comment:1 Changed 5 weeks ago by nickm

Actual Points: .5
Status: newneeds_review

See branch periodic_refactor with PR at https://github.com/torproject/tor/pull/981

comment:2 Changed 5 weeks ago by nickm

Reviewer: dgoulet

comment:3 Changed 4 weeks ago by dgoulet

Status: needs_reviewneeds_revision

Comments on the PR. Also travis is half-unhappy :S.

comment:4 Changed 4 weeks ago by nickm

Status: needs_revisionneeds_review

I've fixed the Travis issues (I hope), removed some now-needless calls to initialize_periodic_events, and added a documentation commit to rename some functions and try to make the code more logical.

comment:5 Changed 4 weeks ago by dgoulet

Status: needs_reviewneeds_revision

Some renaming comments... nothing major, after that this is merge_ready so feel free to update the status once fixed.

comment:6 Changed 4 weeks ago by nickm

Keywords: asn-merge added
Status: needs_revisionmerge_ready

Done; I've added a fixup for those, and made a new periodic_refactor_squashed with PR at https://github.com/torproject/tor/pull/993. Calling this merge_ready but waiting one more time for CI.

comment:7 Changed 4 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.