Opened 5 months ago

Last modified 3 months ago

#30301 new enhancement

Set bridge running status on a timer?

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: neel, teor, ahf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #24490, we changed dirserv_set_bridges_running() to happen immediately before writing to disk, rather than updating each bridge with each getinfo. That's good for the typical use case, but it makes GETINFO less accurate than it was before. Perhaps we should change dirserv_set_bridges_running() to use a timer instead.

If we do this, we should do it after #30293 is merged, since that is likely to change the pattern for periodic events.

Child Tickets

Change History (2)

comment:1 Changed 5 months ago by arma

I'd suggest not overthinking this one. We need to know whether the bridge is Running when we're writing out a networkstatus document for export to bridgedb -- which already happens essentially on a timer, right? Does anything else actually use that value right now? There might be some subtle interactions where Stable and Fast et al are based on which bridges are Running, but even there, I'd push us to investigate what actually consumes this info, and avoid adding complexity for no real improvement.

comment:2 Changed 3 months ago by arma

Ok, I still agree with previous-arma.

It looks like bridgeauth_dump_bridge_status_to_file() gets called from write_bridge_ns_callback() which is called on a timer.

So, we already did this ticket, right?

Note: See TracTickets for help on using tickets.