Maybe add HeaderLine to the bandwidth file specification

In #30255 (moved) karsten comments that there should be a HeaderLine ::= KeyValue NL to simplify the parser in metrics. It's not true in the case of Timestamp NL, but maybe we can just clarify that.

changed milestone to %Tor: 0.4.1.x-final

added bandwidth-file-spec component::core tor/tor milestone::Tor: 0.4.1.x-final points::1 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed tor-spec type::defect labels

Fix typo.

Trac:
Summary: Maybe add HeaderLine to the bandwidht file specification to Maybe add HeaderLine to the bandwidth file specification

Thanks for discussing this spec change! As soon as it's merged, we can simplify the parser in metrics-lib.

Trac:
Cc: N/A to metrics-team

https://github.com/torproject/torspec/pull/80

Trac:
Status: new to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.4.1.x-final

Trac:
Reviewer: N/A to nickm

I don't understand how this interacts with RelayLine -- RelayLine doesn't always match HeaderLine, but I think that RelayLine fields might be allowed?

Also I left a note on the PR.

Trac:
Status: needs_review to needs_revision

Replying to nickm:

I don't understand how this interacts with RelayLine -- RelayLine doesn't always match HeaderLine, but I think that RelayLine fields might be allowed?

Sorry, i don't understand, what do you mean by fields?, and by interacts?, HeaderLine does not contain spaces nor more than one KeyValue.

Replying to nickm:

Also I left a note on the PR.

fixup

Trac:
Status: needs_revision to needs_review

LGTM, squashed and merged.

(My question about RelayLine was wrong -- I didn't understand that this only applied to the headers :/ )

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 8h

moved to tpo/core/tor#30311 (closed)