Opened 5 months ago

Closed 5 weeks ago

#30316 closed defect (fixed)

Vote's 'bandwidth-file-headers' is in wrong order

Reported by: atagar Owned by: nickm
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport, 040-backport, dgoulet-merge
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: ahf Sponsor:

Description

Hi network team. Moria1's present vote places its "bandwidth-file-headers" in the wrong location.

Tor's dir-spec says: "Status documents contain a preamble, an authority section, a list of router status entries, and one or more footer signature, in that order."

The trouble is that our bandwidth-file-headers field is specified as being part of the preamble, whereas moria1 places it after its authority section. Header fields appear in the following order...

  • flag-thresholds (preamble)
  • params (preamble)
  • dir-source (authority section)
  • contact (authority section)
  • shared-rand-participate (authority section)
  • shared-rand-commit (authority section, multiple)
  • shared-rand-previous-value (authority section)
  • shared-rand-current-value (authority section)
  • bandwidth-file-headers (preamble)
  • dir-key-certificate-version (key certificate)
  • ... etc...

As a result Stem does not parse this field: #30282

Child Tickets

Attachments (1)

moria1_vote.txt (11.6 KB) - added by atagar 5 months ago.
Cropped copy of moria1's vote.

Download all attachments as: .zip

Change History (13)

Changed 5 months ago by atagar

Attachment: moria1_vote.txt added

Cropped copy of moria1's vote.

comment:1 Changed 5 months ago by nickm

Milestone: Tor: 0.4.0.x-final

comment:2 Changed 5 months ago by nickm

Keywords: 035-backport added
Owner: set to nickm
Status: newaccepted

comment:3 Changed 5 months ago by nickm

Actual Points: 0
Status: acceptedneeds_review

See my branch bug30316_035.

0.3.5 PR: https://github.com/torproject/tor/pull/987
0.4.0 PR: [fixes conflict and also moves bandwidth-file-digest] https://github.com/torproject/tor/pull/988

comment:4 Changed 5 months ago by atagar

Thanks Nick! For what it's worth looks good to me.

comment:5 Changed 5 months ago by nickm

Status: needs_reviewneeds_revision

whoops, doesn't compile. half a moment...

comment:6 Changed 5 months ago by nickm

Status: needs_revisionneeds_review

Branches fixed and force-pushed.

comment:7 Changed 4 months ago by asn

Reviewer: ahf

comment:8 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:9 Changed 4 months ago by nickm

Keywords: dgoulet-merge added

comment:10 Changed 4 months ago by dgoulet

Keywords: 040-backport added

Merged into 041! Keeping it in 040 for backport!

comment:11 Changed 3 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

Backported to 0.4.0

comment:12 Changed 5 weeks ago by teor

Points: 0
Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.5.
Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

Note: See TracTickets for help on using tickets.