Opened 3 months ago

Closed 2 months ago

#30319 closed task (fixed)

Drop FTE related bits in Tor Browser

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-rbm, TorBrowserTeam201905R, GeorgKoppen201905
Cc: phw Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

FTE is unmaintained and hardly used by Tor Browser users. Moreover, it is not available on all platforms/architectures due to a bunch of reasons (see #24195 for 64bit Windows and #18495 for macOS). Windows is going away entirely as well shortly with the transition to Debian Stretch (see: #29319 and #29307 for the rationale). We should drop the remaining bits in Tor Browser while we are moving to Tor Browser 9 and close #28521 as well.

I had some hope for getting Marionette included into Tor Browser 9 which is why I wrote a patch for getting it tested in our nightly builds (see: #29623). However, it's not clear yet whether that happens or whether that would be a smart idea given its state, alas.

Child Tickets

Change History (10)

comment:1 Changed 3 months ago by gk

Keywords: tbb-rbm added

comment:2 Changed 3 months ago by boklm

In commit adaffbf1c2b49761c44e90f04e6939f0dab9cbba, I removed the FTE tests from the Tor Browser testsuite.

comment:3 Changed 3 months ago by gk

Keywords: TorBrowserTeam201905 GeorgKoppen201905 added

Let's do this early so that we don't have to deal with this part during the esr68 transition. #29319 already removed Windows support.

comment:4 Changed 2 months ago by gk

Note to self: don't forget the winpython key.

comment:5 Changed 2 months ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: newneeds_review

comment:6 Changed 2 months ago by gk

(Oh, and it has a small comment-only change in tor-launcher as well: bug_30319_v2 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30319_v2&id=cce75d8cbe1456b050097ff5a05205c986030a5f))

comment:7 in reply to:  5 ; Changed 2 months ago by boklm

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201905R removed
Status: needs_reviewneeds_revision

Replying to gk:

bug_30319_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30319_v2&id=9434516fe866d5b4da76012caa4ad8cd3fbe5487) has the fix for review.

One minor thing: I think we should also remove the file keyring/pyptlib.gpg.

comment:8 in reply to:  7 ; Changed 2 months ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: needs_revisionneeds_review

Replying to boklm:

Replying to gk:

bug_30319_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30319_v2&id=9434516fe866d5b4da76012caa4ad8cd3fbe5487) has the fix for review.

One minor thing: I think we should also remove the file keyring/pyptlib.gpg.

Good catch. bug_30319_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30319_v3&id=055266551e5a8e56ca4ea9ec1c3eebe0fb1bba4e) has the fixup.

comment:9 in reply to:  8 Changed 2 months ago by boklm

Replying to gk:

Replying to boklm:

Replying to gk:

bug_30319_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30319_v2&id=9434516fe866d5b4da76012caa4ad8cd3fbe5487) has the fix for review.

One minor thing: I think we should also remove the file keyring/pyptlib.gpg.

Good catch. bug_30319_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30319_v3&id=055266551e5a8e56ca4ea9ec1c3eebe0fb1bba4e) has the fixup.

This looks good to me. This is now commit 055266551e5a8e56ca4ea9ec1c3eebe0fb1bba4e on master.

The tor-launcher patch looks good to me too, however I think I don't have push permission on this repo.

comment:10 Changed 2 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Pushed the tor-launcher changes as commit 125c745b8d6dfd04251e7ad2e610aeb539e49fd3.

Note: See TracTickets for help on using tickets.