Adapt macOS toolchain for Firefox 68 ESR

This is the (parent) ticket for adapting our toolchain for macOS bundles built from Firefox 68 ESR.

Trac:
Parent Ticket: #30320 (moved)
Child Ticket(s): #30491 (moved)

added GeorgKoppen201908 TorBrowserTeam201908 component::applications/tor browser ff68-esr owner::tbb-team parent::30320 priority::medium resolution::fixed severity::normal sponsor::44-can status::closed tbb-9.0-must-nightly tbb-rbm type::task labels

Trac:
Type: defect to task

It seems we'll switch to clang-8 for esr68 (https://bugzilla.mozilla.org/show_bug.cgi?id=1540465).

Trac:
Keywords: N/A deleted, GeorgKoppen201905, TorBrowserTeam201905 added

Moving tickets to June

Trac:
Keywords: TorBrowserTeam201905 deleted, TorBrowserTeam201906 added

Moving my tickets to June

Trac:
Keywords: GeorgKoppen201905 deleted, GeorgKoppen201906 added

https://bugzilla.mozilla.org/show_bug.cgi?id=1513798 is relevant here as it contains a number of simplifications and changes we probably want to follow.

Moving my tickets to July.

Trac:
Keywords: GeorgKoppen201906 deleted, GeorgKoppen201907 added

Moving tickets to July

Trac:
Keywords: TorBrowserTeam201906 deleted, TorBrowserTeam201907 added

Starting with 9.0 keywords

Trac:
Keywords: N/A deleted, tbb-9.0-must-nightly added

mac_esr68 in my public tor-browser-build repo is mostly working for Firefox 68.

As a reminder: we need to bump MACOSX_DEPLOYMENT_TARGET to 10.9 now wherever we use it as that is what Mozilla is shipping with ESR68 (actually it might be worth checking that any binary we ship in the bundle has a min OS version of 10.9 now).

Adding Sponsor 44 to ESR68 tickets

Trac:
Sponsor: N/A to Sponsor44-can

Moving tickets to August, part 1

Trac:
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201908 added

Move my tickets.

Trac:
Keywords: GeorgKoppen201907 deleted, GeorgKoppen201908 added

bug_30323_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_30323_v2) is a thing now and contains two patches for review.

Trac:
Keywords: TorBrowserTeam201908 deleted, TorBrowserTeam201908R added
Status: new to needs_review

Replying to gk:

bug_30323_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_30323_v2) is a thing now and contains two patches for review.

This first patch looks good to me. I merged it to master as commit 1877dbbdf499e51beb6dd5be2d53e74f57428130.

For the second patch, it seems we still have some -mmacosx-version-min=10.7 in projects/go-webrtc/config. We also have a comment mentioning 10.7 in projects/rust/build. While at it, to avoid duplicating the macos target in many place, maybe we could define it in a variable in rbm.conf.

Trac:
Keywords: TorBrowserTeam201908R deleted, TorBrowserTeam201908 added
Status: needs_review to needs_revision

Replying to boklm:

For the second patch, it seems we still have some -mmacosx-version-min=10.7 in projects/go-webrtc/config. We also have a comment mentioning 10.7 in projects/rust/build. While at it, to avoid duplicating the macos target in many place, maybe we could define it in a variable in rbm.conf.

I suggest the following fixup patch: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31465&id=7a01c99641fcdc88a94c94dccb2698fbb7d82bee

Looks good, thanks. Merged to master with commit 039f83d716b5050d6faeda8e1bbce3a674a9f2d5.

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

closed

mentioned in issue #30491 (moved)

mentioned in issue #31465 (moved)

mentioned in issue #31517 (moved)

mentioned in issue #30320 (moved)

moved to tpo/applications/tor-browser#30323 (closed)

mentioned in issue tpo/applications/tor-browser-build#31517