Opened 4 months ago

Closed 31 hours ago

#30323 closed task (fixed)

Adapt macOS toolchain for Firefox 68 ESR

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908, GeorgKoppen201908
Cc: boklm Actual Points:
Parent ID: #30320 Points:
Reviewer: Sponsor: Sponsor44-can

Description

This is the (parent) ticket for adapting our toolchain for macOS bundles

built from Firefox 68 ESR.

Child Tickets

TicketStatusOwnerSummaryComponent
#30491closedtbb-teamMove our macOS builds to Debian StretchApplications/Tor Browser

Change History (18)

comment:1 Changed 4 months ago by gk

Type: defecttask

comment:2 Changed 4 months ago by gk

It seems we'll switch to clang-8 for esr68 (https://bugzilla.mozilla.org/show_bug.cgi?id=1540465).

comment:3 Changed 4 months ago by gk

Keywords: TorBrowserTeam201905 GeorgKoppen201905 added

comment:4 Changed 2 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:5 Changed 2 months ago by gk

Keywords: GeorgKoppen201906 added; GeorgKoppen201905 removed

Moving my tickets to June

comment:6 Changed 8 weeks ago by gk

https://bugzilla.mozilla.org/show_bug.cgi?id=1513798 is relevant here as it contains a number of simplifications and changes we probably want to follow.

comment:7 Changed 8 weeks ago by gk

Keywords: GeorgKoppen201907 added; GeorgKoppen201906 removed

Moving my tickets to July.

comment:8 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:9 Changed 5 weeks ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:10 Changed 5 weeks ago by gk

mac_esr68 in my public tor-browser-build repo is mostly working for Firefox 68.

comment:11 Changed 3 weeks ago by gk

As a reminder: we need to bump MACOSX_DEPLOYMENT_TARGET to 10.9 now wherever we use it as that is what Mozilla is shipping with ESR68 (actually it might be worth checking that any binary we ship in the bundle has a min OS version of 10.9 now).

comment:12 Changed 3 weeks ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:13 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving tickets to August, part 1

comment:14 Changed 4 days ago by gk

Keywords: GeorgKoppen201908 added; GeorgKoppen201907 removed

Move my tickets.

comment:15 Changed 4 days ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201908 removed
Status: newneeds_review

bug_30323_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_30323_v2) is a thing now and contains two patches for review.

comment:16 in reply to:  15 ; Changed 2 days ago by boklm

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201908R removed
Status: needs_reviewneeds_revision

Replying to gk:

bug_30323_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_30323_v2) is a thing now and contains two patches for review.

This first patch looks good to me. I merged it to master as commit 1877dbbdf499e51beb6dd5be2d53e74f57428130.

For the second patch, it seems we still have some -mmacosx-version-min=10.7 in projects/go-webrtc/config. We also have a comment mentioning 10.7 in projects/rust/build. While at it, to avoid duplicating the macos target in many place, maybe we could define it in a variable in rbm.conf.

comment:17 in reply to:  16 Changed 43 hours ago by boklm

Replying to boklm:

For the second patch, it seems we still have some -mmacosx-version-min=10.7 in projects/go-webrtc/config. We also have a comment mentioning 10.7 in projects/rust/build. While at it, to avoid duplicating the macos target in many place, maybe we could define it in a variable in rbm.conf.

I suggest the following fixup patch:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31465&id=7a01c99641fcdc88a94c94dccb2698fbb7d82bee

comment:18 Changed 31 hours ago by gk

Resolution: fixed
Status: needs_revisionclosed

Looks good, thanks. Merged to master with commit 039f83d716b5050d6faeda8e1bbce3a674a9f2d5.

Note: See TracTickets for help on using tickets.