Opened 3 months ago

Last modified 5 hours ago

#30324 new task

Adapt Android toolchain for Firefox 68 ESR

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201907, tbb-9.0-must-nightly
Cc: boklm, sisbell Actual Points:
Parent ID: #30320 Points:
Reviewer: Sponsor:

Description

This is the (parent) ticket for adapting our toolchain for Android bundles

built from Firefox 68 ESR.

Child Tickets

TicketStatusOwnerSummaryComponent
#30460needs_reviewtbb-teamUpdate TOPL Project to Use Android Toolchain (Firefox 68)Applications/Tor Browser
#30461needs_reviewtbb-teamUpdate tor-android-service Project to Use Android Toolchain (Firefox 68)Applications/Tor Browser
#30665newtbb-teamGet Firefox 68 ESR Working with latest android toolchainApplications/Tor Browser
#31173needs_reviewtbb-teamUpdate android-toolchain project to match firefoxApplications/Tor Browser

Change History (11)

comment:2 Changed 2 months ago by gk

Cc: sisbell added
Keywords: TorBrowserTeam201905 added

comment:3 Changed 2 months ago by sisbell

I built firefox code and it looks like we will need tools for the following

  • Android NDK 17b
  • Build tools 27.0.3
  • Platform for SDK 28

Min sdkVersion is still 16

I noticed other downloads. These are not part of the Android toolchain but worth noting

  • Rust 1.34.1
  • node
  • clang
  • cbindgen
  • clang-tidy
  • nasm

comment:4 Changed 2 months ago by sisbell

Uses Gradle 4.10.2

comment:5 Changed 7 weeks ago by sisbell

Under 4.10.2 there is an error related to not being able to connect to gradle daemon. We need to start gradle using --no-daemon on projects dependent on updated toolchain.The daemon caches information when running multiple builds. Since we run build once per container, disabling daemon will have no impact.

comment:6 Changed 7 weeks ago by sisbell

In each project, we will also need to set the following property in the gradle.properties file. Otherwise we can get a failure to start due to missing licenses.

android.builder.sdkDownload=false

comment:7 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:8 Changed 11 days ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:9 Changed 38 hours ago by sisbell

The latest work is on branch 0717. This build depends on my branch of tor-android-service, rather than the one at torproject.

https://github.com/sisbell/tor-browser-build/commits/0717

I just did a rebase with latest from master and their were some conflicts. I fixed those but now need to do a clean build to make sure everything is still working. I'll mark this for review once I verify the build sometime today.

comment:10 in reply to:  4 Changed 17 hours ago by cypherpunks

Replying to sisbell:

Uses Gradle 4.10.2

NOTE: Gradle 4.10 has had three patch releases. You should use the latest patch release (4.10.3).
https://docs.gradle.org/4.10.3/release-notes.html#upgrade-instructions

comment:11 Changed 5 hours ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

Note: See TracTickets for help on using tickets.