Opened 5 months ago

Closed 5 months ago

#30325 closed task (fixed)

Remove bison from the list of default packages on android and osx builds

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201904R, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While testing the changes from #29981, gk found that bison is not really needed, although we have it in the list of dependencies for the android build.

I think bison was added to the list of default packages to be able to build binutils, with commit 78a5009fa4e0fc3e7e4ccd854df7dd3833b6b174. As we don't build binutils during the osx-x86_64 build, we can probably remove binutils there too.

Child Tickets

Change History (2)

comment:1 Changed 5 months ago by boklm

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed
Status: newneeds_review

There is a patch for review in branch bug_30325_v3:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30325_v3&id=92f1239bac2f4f20df38acfe587b1ef5bcceebd2

I checked that all platforms still build correctly with this patch.

comment:2 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Merged to master (commit a933db4a6d08879842d3898b752dccfd8e524e72).

Note: See TracTickets for help on using tickets.