Opened 3 weeks ago

Last modified 3 weeks ago

#30334 new enhancement

build_go_lib for executables?

Reported by: JeremyRand Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Is there a reason that build_go_lib (from the go project in tor-browser-build) is only used for libraries and not executables? At first glance, it seems to me that using it (or something very similar) for executables as well would cut down on boilerplate / code duplication. Would a patch be accepted that adapted the meek/obfs4/snowflake projects in tor-browser-build to use build_go_lib (or an executable-focused analogue of it)?

Child Tickets

Change History (2)

comment:1 Changed 3 weeks ago by gk

Cc: boklm added
Keywords: tbb-rbm added

Not sure actually. boklm might know, though.

comment:2 Changed 3 weeks ago by boklm

Would a patch be accepted that adapted the meek/obfs4/snowflake projects in tor-browser-build to use build_go_lib (or an executable-focused analogue of it)?

I think yes, if it allows to cut down on boilerplate / code duplication and does not make things more complex.

The reason I added build_go_lib was that all the go libraries are built in the same way, with little differences, so having some instructions that works for all of them was easy. For meek/obfs4/snowflake, there are lot more differences, so it's more difficult to do, and less clear whether it is worth it.

Note: See TracTickets for help on using tickets.