Changes between Version 1 and Version 2 of Ticket #30365, comment 10


Ignore:
Timestamp:
May 30, 2019, 2:54:16 AM (8 months ago)
Author:
arma
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30365, comment 10

    v1 v2  
    55s/have its StreamID=0/has its StreamID=0/
    66
    7 I'm confused that the digest of a version 1 sendme cell has 20 bytes, but then there's some mention of 4 also? I think the 4 is because that's what how many bytes we actually put in a relay header? What if one side remembers 4 bytes, but then gets a v1 sendme with a DATA_LEN of 20? Should it compare just the first 4 bytes Or the last 4 bytes? As currently written, if the DATA_LEN in a v1 sendme is 6, then we're supposed to read 20 bytes, which is unintuitively more than the 6 that it said it included?
     7I'm confused that the digest of a version 1 sendme cell has 20 bytes, but then there's some mention of 4 also? I think the 4 is because that's what how many bytes we actually put in a relay header? What if one side remembers 4 bytes, but then gets a v1 sendme with a DATA_LEN of 20? Should it compare just the first 4 bytes? Or the last 4 bytes? As currently written, if the DATA_LEN in a v1 sendme is 6, then we're supposed to read 20 bytes, which is unintuitively more than the 6 that it said it included?
    88
    99Should we include in the spec some mention of leaving some bytes unused in some relay_data cells, to ensure there is unpredictable data going through?