Child Tickets

Change History (15)

comment:1 Changed 7 months ago by gk

Keywords: tbb-fingerprinting-resolution TorBrowserTeam201905 added

comment:2 Changed 7 months ago by gk

That's not working for me. I think the reason is that there is no Services.locale.appLocaleAsLangTag on esr60 and hence this breaks early on. You'll see something like

TypeError: Services.locale.appLocaleAsLangTag is undefined[Learn More]  RFPHelper.jsm:189:5

in the browser console.

comment:4 Changed 7 months ago by gk

Keywords: TorBrowserTeam201905R GeorgKoppen201905 added; TorBrowserTeam201905 removed
Status: newneeds_review

Okay, I have those patches another try and played with it. Nice work, tjr! bug_30372_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_30372_v2) has backport of the seven patches to Tor Browser up for review.

tjr: One thing I noticed with letterboxing active: if I open e.g. the find bar then letterboxing does not take that into account (e.g. before the height was 600px and after the find bar showed up it's just 563px). That seems like a bug to me (not sure if that's already tracked somewhere or not).

comment:5 Changed 7 months ago by Thorin

The findbar is only toggled on/off per tab, whereas the letterboxing is set per window (and all the tabs in that window)

comment:6 Changed 7 months ago by tom

https://bugzilla.mozilla.org/show_bug.cgi?id=1546832 is for the Find Bar. It is not fixed yet; but I don't think it's a blocker for putting this in Nightly...

comment:7 Changed 7 months ago by tom

Also; there were some non-functional changes on the latest patch; https://phabricator.services.mozilla.com/D29759?download=true may be good to take just to stay in sync with upstream - it could avoid a conflict if I manage find time to fix 1546832

comment:8 in reply to:  7 Changed 7 months ago by gk

Replying to tom:

Also; there were some non-functional changes on the latest patch; https://phabricator.services.mozilla.com/D29759?download=true may be good to take just to stay in sync with upstream - it could avoid a conflict if I manage find time to fix 1546832

Sounds good. I updated bug_30372_v2 with the backport (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_30372_v2&id=d5412b0b31227973660d5532e6d0a8228b580cf3).

comment:9 Changed 7 months ago by acat

I think there's something wrong with https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-FILE-j4tddtqktkpxt66evkb5/D29759.diff. The defaultRounding function was deleted but I don't see that change in https://phabricator.services.mozilla.com/D29759?download=true. Also, onst instead of const :).

comment:10 Changed 7 months ago by acat

Status: needs_reviewneeds_revision

comment:12 Changed 7 months ago by tom

The last patch in the series I posted above has landed as https://hg.mozilla.org/mozilla-central/rev/6d2d7856e468 so the last two patches in that branch can be dropped in favor of this single one.

comment:13 in reply to:  9 Changed 7 months ago by gk

Status: needs_revisionneeds_review

Replying to acat:

I think there's something wrong with https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-FILE-j4tddtqktkpxt66evkb5/D29759.diff. The defaultRounding function was deleted but I don't see that change in https://phabricator.services.mozilla.com/D29759?download=true. Also, onst instead of const :).

Ugh, the onst :(. I've fixed that in the new banch bug_30372_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_30372_v3), following tom's advice to drop the last two patches in favor of the one new one. Regarding defaultRounding it got added in

https://hg.mozilla.org/try/rev/0b1eef9eeb06668fc06b3b4d877daaf957c3c1da

. However, the patch tom pointed to to keep us in sync is probably from a later state where defaultRounding was already gone. I adapted the patch for our esr60.

comment:14 Changed 7 months ago by acat

Looks good to me now.

comment:15 Changed 7 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Pushed to tor-browser-60.6.1esr-9.0-1 as commits
0958b375400c51ddd1c61cda14acae686697729b
7f3ce3ef4cf86690864a4abd7ca58a9e5dbb087f
69e7b6d159f3d7ec4d8e0987afe1925ade94c0f6
06bed4d6845f681755c1e51db9497aeeaa5cd259
610ad333716499f5f9cf704a1dd97e07d276f572
003019c16626dc515d5fe9defb999be1ab8ad397
166a752ab22ef1415c250eff37e1ada3f2f24915
.

Note: See TracTickets for help on using tickets.