Opened 5 months ago

Closed 4 weeks ago

#30376 closed defect (fixed)

Use Rust 1.34 for Tor Browser 9

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201908R, tbb-9.0-must-nightly, GeorgKoppen201908
Cc: boklm, sisbell Actual Points:
Parent ID: #30320 Points:
Reviewer: Sponsor: Sponsor44-can

Description

https://bugzilla.mozilla.org/show_bug.cgi?id=1536543 set the Rust requirement to 1.34 and we should follow that if there are no strong reasons against that. While adapting our Rust part we should/could consider the following tasks:

1) We don't need to build a newer Rust anymore just for the tor nightlies
2) Given our work on the mingw-w64/clang toolchain for #28328, which requites a pretty new toolchain, we could test using the llvm we already build for that one to copmile Rust instead of building an own llvm during Rust build
3) We need to switch the target for armv7 to thumbv7neon-linux-androidabi (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1521734 for more details).

Child Tickets

Change History (14)

comment:1 Changed 4 months ago by gk

Cc: sisbell added
Keywords: TorBrowserTeam201905 GeorgKoppen201905 added

comment:2 Changed 4 months ago by sisbell

It looks like the Tegra 2 armv7 devices don't support the neon instruction set so we will need to make sure to get a list of devices and exclude them in Google Play (not sure about whether f-droid has such an option).

comment:5 Changed 3 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:6 Changed 3 months ago by gk

Keywords: GeorgKoppen201906 added; GeorgKoppen201905 removed

Moving my tickets to June

comment:7 Changed 3 months ago by gk

Keywords: GeorgKoppen201907 added; GeorgKoppen201906 removed

Moving my tickets to July.

comment:8 Changed 2 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:9 Changed 2 months ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:10 Changed 6 weeks ago by boklm

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907 removed
Status: newneeds_review

I am proposing the following fixup commit, to squash on top of f37ade326575511a6c9f63c4580ae70128d0c98d from branch gk/linux_esr68_v7:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30376&id=fe2d155eff5fcc2340e97fe80f14ea8981ae6b8a

This cleans up the things we did to support building multiple versions of rust, and rebase the unwind.patch patch onto the new rust version (although I did not check that the Windows build actually works).

comment:11 Changed 6 weeks ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:12 in reply to:  10 ; Changed 6 weeks ago by gk

Replying to boklm:

I am proposing the following fixup commit, to squash on top of f37ade326575511a6c9f63c4580ae70128d0c98d from branch gk/linux_esr68_v7:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30376&id=fe2d155eff5fcc2340e97fe80f14ea8981ae6b8a

This cleans up the things we did to support building multiple versions of rust, and rebase the unwind.patch patch onto the new rust version (although I did not check that the Windows build actually works).

The fixup looks overall good, but, no the Windows build breaks. I fixed this up in commit f0d2a56960f2981c67ab5fffb323ccbabceb0f54 and added another fixup (commit 0681d468be25e8eaf3e62b73dd54f51fcf8e29f8) on bug_30376_win_test. I squashed this and merged it to master (commit d4f7c37aefc702fb9a66604cdf05bd8977036fc8).

I'll leave this bug open to get a final ack for the two fixups.

comment:13 Changed 4 weeks ago by gk

Keywords: GeorgKoppen201908 added; GeorgKoppen201907 removed

Move my tickets.

comment:14 in reply to:  12 Changed 4 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

I'll leave this bug open to get a final ack for the two fixups.

The fixups look good to me, so closing this bug.

Note: See TracTickets for help on using tickets.