Opened 3 weeks ago

Closed 2 weeks ago

Last modified 33 hours ago

#30377 closed task (fixed)

Remove Selfrando from our build system

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201905R, GeorgKoppen201905
Cc: Actual Points:
Parent ID: #25930 Points:
Reviewer: Sponsor:

Description

We don't plan to move forward with Selfrando deployment as it is not much more work for a browser attacker to bypass it, it's not available on all platforms, and it has some issues (like delayed load in e10s mode, see: #26579). Additionally, it's work to fix build breakage (in elfutils) to make what we build with compatible with newer GCCs. And I expect another round of Firefox compilation issues when switching to ESR 68.

All in all I think the gains for our alphas are not worth the effort.

Child Tickets

Change History (5)

comment:1 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: newneeds_review

comment:2 in reply to:  1 Changed 2 weeks ago by boklm

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201905R removed
Status: needs_reviewneeds_revision

Replying to gk:

bug_30377 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30377&id=082d9d8b446573ba99ac687b6fb5b9586b856ecc) has the fix for this ticket.

I think we can also remove the export SELFRANDO_write_layout_file= line from projects/tor-browser/RelativeLink/start-tor-browser.

comment:3 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: needs_revisionneeds_review

comment:4 in reply to:  3 Changed 2 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Good catch! bug_30377_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30377_v2&id=9f2de1690a822e1933356065010378f60ea2cf2c) has the updated patch.

This looks good to me. I merged it to master as commit 9f2de1690a822e1933356065010378f60ea2cf2c.

comment:5 Changed 33 hours ago by cypherpunks

Another advantage is that memory now frees up much more when handling opening/closing multiple tabs. RAM usage looks much more better overall. I'm sold.

Note: See TracTickets for help on using tickets.