Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3039 closed defect (fixed)

git 29e0d708 broke LastWritten state entry

Reported by: arma Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version: Tor: 0.2.2.14-alpha
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In Tor 0.2.2.14-alpha, we added two bugs:

A) The LastWritten element of our state became the time of the *previous* time we wrote the file, rather than the time of this writing

B) When we fail to write the state file, we set LastWritten to -1, which is no good when we hand it to format_iso_time() in read_bandwidth_usage().

This bug was discovered while looking at #2077.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by arma

Status: newneeds_review

Check out my branch bug3039.

comment:2 Changed 8 years ago by nickm

Looks good. Merged.

comment:3 Changed 8 years ago by arma

Resolution: fixed
Status: needs_reviewclosed

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.