Opened 5 months ago

Last modified 4 months ago

#30406 needs_revision defect

Refactor bandwidth file header constants

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: juga Actual Points:
Parent ID: #30255 Points: 1
Reviewer: asn Sponsor:

Description

As commented in https://trac.torproject.org/projects/tor/ticket/30196#comment:9.
It would need only 2 changes, but since we have #29057, refactor to start replacing as much as possible sbws code with stem's one so that we don't need to maintain 2 versions.

Child Tickets

TicketStatusOwnerSummaryComponent
#30643newAdd Travis CI jobs with stem 1.7.0 and stem masterCore Tor/sbws

Change History (6)

comment:1 Changed 5 months ago by juga

Status: assignedneeds_review

comment:2 Changed 5 months ago by asn

Reviewer: asn

comment:3 Changed 4 months ago by asn

Status: needs_reviewneeds_revision

Did a review. Might need revisions or just clarifications. Putting it in needs_revision anyway.

comment:4 Changed 4 months ago by juga

I replied to the questions. Not changing to needs_review because not doing any commit yet until knowing your opinion on my answers.

comment:5 Changed 4 months ago by juga

Status: needs_revisionneeds_review

Ok, i made the changes i commented in the PR.

comment:6 Changed 4 months ago by teor

Status: needs_reviewneeds_revision

This pull request creates a lot of technical debt.

Let's write the code for stem 1.7.0 and stem master now, and test it with stem 1.7.0 and stem master using CI.

Note: See TracTickets for help on using tickets.