Opened 7 months ago

Last modified 5 months ago

#30409 needs_information defect

Some of our tests require internet connectivity / an IPv4 stack

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ipv6, tor-hs, tor-tests, tor-ci
Cc: rl1987, ln5 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We got word from an onion service operator that they had to disable some of our tests because they wouldn't work in their ipv6-only setup.

In particular they mentioned the following tests (or functions): get_if_addrs_list_internal, get_if_addrs_list_no_internal, get_if_addrs, status_vote_current_consensus_ns

We should probably investigate this.

Child Tickets

TicketStatusOwnerSummaryComponent
#30804closednickmutil/socketpair_ersatz test requires configured networkCore Tor/Tor

Change History (12)

comment:1 Changed 7 months ago by rl1987

Cc: rl1987 added

comment:2 Changed 7 months ago by nickm

Keywords: tor-ci added

comment:3 Changed 7 months ago by nickm

Keywords: 041-should added

comment:4 Changed 6 months ago by nickm

I managed to repro a failure in util/socketpair_ersatz using unshare, and so made a child ticket to fix it. Everything else in ./src/test/test worked fine.

comment:5 Changed 6 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:6 Changed 6 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: unspecified
Owner: nickm deleted
Status: acceptedassigned

comment:7 Changed 6 months ago by nickm

Status: assignedneeds_information

Hi! I'd be glad to try to fix this stuff, but I'd need more info to do so. Reproduction instructions would be best, along with complete logs from the failing tests.

comment:8 Changed 6 months ago by teor

Cc: ln5 added

I regularly run our tests on a macOS VM without any network connection. (But with IPv4 and IPv6 stacks.) They work fine.

Our CI runs tests online with IPv4 (Travis Linux), and dual-stack (Travis Mac).
(Appveyor doesn't mention IP stacks in its documentation, we use it for Windows builds.)

I'll try to run tests on macOS and Linux VMs with only an IPv6 stack.

Linus also had some IPv6 only machines. I don't know if they're still available.

comment:9 Changed 6 months ago by asn

Sent an email to the bug reporter to clarify in this ticket :)

comment:10 in reply to:  8 Changed 6 months ago by ln5

Replying to teor:

Linus also had some IPv6 only machines. I don't know if they're still available.

The Linux system is gone and the FreeBSD system is in need of a shape-up. Let me know if I should bring one or both back!

comment:11 Changed 6 months ago by ln5

To be clear, these would have IP stacks but no IPv4 connectivity.

comment:12 Changed 5 months ago by nickm

Keywords: 041-should removed
Note: See TracTickets for help on using tickets.