Opened 6 months ago

Closed 5 months ago

#30415 closed defect (fixed)

broken url in metrics.tpo

Reported by: gaba Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gaba)

There is a broken url that needs to be replaced.

Broken url: https://www.torproject.org/about/overview#thesolution

(linked from https://metrics.torproject.org/exonerator.html)

It should be replaced by: https://2019.www.torproject.org/about/overview.html.en#thesolution

Thanks

Child Tickets

Change History (8)

comment:1 Changed 6 months ago by gaba

Description: modified (diff)

comment:2 Changed 5 months ago by karsten

Status: newneeds_review

I'd rather not want to link to a temporary page and change that once again whenever the Tor website redesign has progressed more and covered the linked page. It feels like a too tight integration between the Metrics website and the Tor website.

How about we just remove the three links under "About Tor" on https://metrics.torproject.org/exonerator.html? After all, we have links to the Tor website and its contact page in the Metrics website footer which we didn't have when ExoneraTor was a website of its own.

Thoughts?

(Making this change requires putting out a new ExoneraTor version.)

comment:3 Changed 5 months ago by irl

I think we can remove the first link, swap /about/overview for /about and /about/contact for /contact. I think it's unlikely those links will change again any time soon.

comment:4 Changed 5 months ago by irl

Status: needs_reviewneeds_revision

comment:5 Changed 5 months ago by karsten

Status: needs_revisionneeds_review

Sure, works for me, too. Please review commit 41c7671 in my task-30415 branch.

comment:6 Changed 5 months ago by irl

Status: needs_reviewmerge_ready

comment:7 Changed 5 months ago by karsten

Status: merge_readyneeds_information

Merged to ExoneraTor master. Opening a new ticket for the ExoneraTor release and leaving this one open (in needs_information) for the necessary metrics-web patch.

comment:8 Changed 5 months ago by karsten

Resolution: fixed
Status: needs_informationclosed

ExoneraTor 4.1.0 is released, metrics-web is updated. This fixes the issue! Closing.

Note: See TracTickets for help on using tickets.